Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new rich text editor & redesigned Posted Composer #1740

Merged
merged 4 commits into from Dec 24, 2019

Conversation

defnax
Copy link
Contributor

@defnax defnax commented Dec 19, 2019

  • Added new Rich Text Editor
  • Redesigned the Create Post Composer for Posted Links
  • When only link is added display different thumbnail & some small fixes.

The new Rich Text Editor can be soon easyly embeded for Channels & Forums Composer too.

image

this composer can be more improved some ideas:

  • selection box for subscribed topics. (for easy switch where want to post)
    image

when someone want improve it please make a pr after this Pr is merged.

* Added new Rich Text Editor
* Redesigned the Create Post Composer for Posted Links
* When only link is added display different thumbnail
@defnax defnax requested a review from csoler December 19, 2019 18:22
@felisucoibi
Copy link
Contributor

ole y ole!!! you are the best!

@@ -0,0 +1,101 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a license problem here. retroshare-gui is AGPLv3+. Depending on where you found this file, it may be possible to re-license it with AGPLv3+ as well,

Copy link
Contributor Author

@defnax defnax Dec 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csoler what now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you ask the author if you can relicense this file to AGPLv3+ ? If not, we cannot add this file. If it comes from Qt examples, it shouldn't be a problem if I remember correctly.

@@ -0,0 +1,620 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here about license.

@csoler csoler merged commit 5afa2a1 into RetroShare:master Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants