Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Two Factor Authentication #147

Merged
merged 27 commits into from Oct 23, 2020
Merged

Implement Two Factor Authentication #147

merged 27 commits into from Oct 23, 2020

Commits on Oct 18, 2020

  1. Implement Two Factor Authentication

    @raccube
    raccube committed Oct 18, 2020
    Copy the full SHA
    141ff59 View commit details
    Browse the repository at this point in the history

  2. Fix OTP auth triggering for users who haven't set it up 

    I thought I could be clever by using a null secret key as an indicator of it being disabled
    @raccube
    raccube committed Oct 18, 2020
    Copy the full SHA
    25410e1 View commit details
    Browse the repository at this point in the history

  3. Fix detaching, improve UI for attaching 2FA

    @raccube
    raccube committed Oct 18, 2020
    Copy the full SHA
    4ce5dfc View commit details
    Browse the repository at this point in the history

  4. Add help text and confirmation for disabling 2FA

    @raccube
    raccube committed Oct 18, 2020
    Copy the full SHA
    d550e6d View commit details
    Browse the repository at this point in the history

  5. Shorten 2FA setup OTP validation field

    @raccube
    raccube committed Oct 18, 2020
    Copy the full SHA
    5447e90 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2020

  1. Redirect away from two factor entry page if no target user is set in … 

    …session
    @raccube
    raccube committed Oct 19, 2020
    Copy the full SHA
    00da21a View commit details
    Browse the repository at this point in the history

  2. Use controller for setting up QR Code

    @raccube
    raccube committed Oct 19, 2020
    Copy the full SHA
    433f1d4 View commit details
    Browse the repository at this point in the history

  3. Add F-Droid & GitHub links for Android TOTP App

    @raccube
    raccube committed Oct 19, 2020
    Copy the full SHA
    70b8053 View commit details
    Browse the repository at this point in the history

  4. haml-lint fixes

    @raccube
    raccube committed Oct 19, 2020
    Copy the full SHA
    dc88ac3 View commit details
    Browse the repository at this point in the history

  5. Fix remaining lint warnings

    @raccube
    raccube committed Oct 19, 2020
    Copy the full SHA
    ea99805 View commit details
    Browse the repository at this point in the history

  6. Make OTP secret longer

    @raccube
    raccube committed Oct 19, 2020
    Copy the full SHA
    3211f8f View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2020

  1. Add basic login form tests

    @raccube
    raccube committed Oct 20, 2020
    Copy the full SHA
    febcf34 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2020

  1. Add tests for security settings page

    @raccube
    raccube committed Oct 21, 2020
    Copy the full SHA
    556050a View commit details
    Browse the repository at this point in the history

  2. Rename settings partials to match naming conventions

    @raccube
    raccube committed Oct 21, 2020
    Copy the full SHA
    d3cc421 View commit details
    Browse the repository at this point in the history

  3. Fix bad refactor

    @raccube
    raccube committed Oct 21, 2020
    Copy the full SHA
    68b1bbb View commit details
    Browse the repository at this point in the history

  4. Add trailing new line to settings partials

    @raccube
    raccube committed Oct 21, 2020
    Copy the full SHA
    d89d7a0 View commit details
    Browse the repository at this point in the history

  5. Add test for #update_2fa endpoint

    @raccube
    raccube committed Oct 21, 2020
    Copy the full SHA
    55de0e4 View commit details
    Browse the repository at this point in the history

  6. Add test for #destroy_2fa endpoint

    @raccube
    raccube committed Oct 21, 2020
    Copy the full SHA
    482b799 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Implement @nilsding's review changes

    @raccube
    raccube committed Oct 23, 2020
    Copy the full SHA
    d7a1750 View commit details
    Browse the repository at this point in the history

  2. Use the same string for 2FA failures

    @raccube
    raccube committed Oct 23, 2020
    Copy the full SHA
    66cccbb View commit details
    Browse the repository at this point in the history

  3. Remove user/sessions#two_factor_entry

    @raccube
    raccube committed Oct 23, 2020
    Copy the full SHA
    7021562 View commit details
    Browse the repository at this point in the history

  4. Remove I18n. prefix

    @raccube
    raccube committed Oct 23, 2020
    Copy the full SHA
    0f80bce View commit details
    Browse the repository at this point in the history

  5. Add string for views.auth.2fa.errors.invalid_code

    @raccube
    raccube committed Oct 23, 2020
    Copy the full SHA
    75c7827 View commit details
    Browse the repository at this point in the history

  6. Remove #two_factor_entry test

    @raccube
    raccube committed Oct 23, 2020
    Copy the full SHA
    7f4d6cd View commit details
    Browse the repository at this point in the history

  7. Apply styling to OTP attempt field

    @raccube
    raccube committed Oct 23, 2020
    Copy the full SHA
    37d2b43 View commit details
    Browse the repository at this point in the history

  8. Auto focus OTP validation field on setup page

    @raccube
    raccube committed Oct 23, 2020
    Copy the full SHA
    ee4b7e2 View commit details
    Browse the repository at this point in the history

  9. Add drift period

    @raccube
    raccube committed Oct 23, 2020
    Copy the full SHA
    d20f527 View commit details
    Browse the repository at this point in the history