Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scheduled job to clean up orphaned inbox entries #1581

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

pixeldesu
Copy link
Member

Feature and bugfix in one PR!

This PR adds sidekiq-scheduler and our first scheduled job to go along with it, InboxCleanupScheduler.

This job runs every minute and cleans up orphaned inbox entries. This is a bug fix to prevent broken inboxes due to "somewhere down the line" deletion of something causing this behaviour. There is no case where this should happen, as to why the test case for this scheduler even has to disable validations on saving the broken record that is scheduled for deletion.

@nilsding this works fine locally without any change to the setup, but I'm not sure about how this ends up working with our deployment and what changes need to be made to accommodate this.

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8cb2f6) 95.71% compared to head (6912cf7) 95.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1581      +/-   ##
==========================================
+ Coverage   95.71%   95.76%   +0.04%     
==========================================
  Files         174      175       +1     
  Lines        2706     2714       +8     
==========================================
+ Hits         2590     2599       +9     
+ Misses        116      115       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixeldesu pixeldesu linked an issue Jan 22, 2024 that may be closed by this pull request
@pixeldesu pixeldesu merged commit d044705 into main Jan 22, 2024
12 checks passed
@pixeldesu pixeldesu deleted the fix/inbox-cleanup-scheduler branch January 22, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inbox can't be opened.
1 participant