Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max question content limit of 32,768 characters #1666

Merged
merged 3 commits into from
Mar 10, 2024

Conversation

pixeldesu
Copy link
Member

Adds a maximum character limit to questions regardless of the picked setting. Using over 32768 characters (number picked because 512 is also a power of 2) will now also raise Errors:QuestionTooLong.

@github-actions github-actions bot added the bugfix Pull Requests that fix a bug label Mar 10, 2024
Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.84%. Comparing base (bb24124) to head (7bed151).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1666   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files         179      179           
  Lines        2765     2770    +5     
=======================================
+ Hits         2650     2655    +5     
  Misses        115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixeldesu pixeldesu merged commit 165fbd8 into main Mar 10, 2024
12 checks passed
@pixeldesu pixeldesu deleted the bugfix/long-question-length branch March 10, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull Requests that fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant