Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move profile fields to seperate table #213

Merged
merged 10 commits into from
Dec 25, 2021
Merged

Move profile fields to seperate table #213

merged 10 commits into from
Dec 25, 2021

Conversation

raccube
Copy link
Contributor

@raccube raccube commented Dec 19, 2021

Closes #210

@codecov
Copy link

codecov bot commented Dec 19, 2021

Codecov Report

Merging #213 (842f51d) into master (2c7d7b7) will increase coverage by 0.00%.
The diff coverage is 44.44%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   59.91%   59.91%           
=======================================
  Files          88       89    +1     
  Lines        2068     2088   +20     
=======================================
+ Hits         1239     1251   +12     
- Misses        829      837    +8     
Impacted Files Coverage Δ
app/helpers/application_helper/graph_methods.rb 93.75% <ø> (ø)
app/helpers/user_helper.rb 22.22% <0.00%> (ø)
app/models/services/tumblr.rb 44.44% <0.00%> (ø)
app/workers/export_worker.rb 0.00% <0.00%> (ø)
lib/exporter.rb 0.00% <0.00%> (ø)
app/models/profile.rb 68.75% <68.75%> (ø)
app/controllers/user_controller.rb 45.60% <85.71%> (+1.90%) ⬆️
app/models/user.rb 78.40% <100.00%> (+2.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c7d7b7...842f51d. Read the comment docs.

@raccube raccube requested review from pixeldesu and nilsding and removed request for pixeldesu December 21, 2021 23:25
@raccube raccube marked this pull request as ready for review December 21, 2021 23:26
Copy link
Member

@pixeldesu pixeldesu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did testing across multiple areas of the site, including follows etc. and I couldn't find any errors or missed references to non .profile areas anymore. LGTM 👍

@raccube raccube merged commit 053ebaf into master Dec 25, 2021
@raccube raccube deleted the refactor/profile branch December 25, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move profile fields to seperate table
2 participants