Port User functionality to TypeScript #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
=======================================
Coverage 59.91% 59.91%
=======================================
Files 88 88
Lines 2068 2068
=======================================
Hits 1239 1239
Misses 829 829 Continue to review full report at Codecov.
|
raccube
reviewed
Dec 25, 2021
| @@ -0,0 +1,9 @@ | |||
| type OnCallbackFunction = (event: Event) => void; | |||
There was a problem hiding this comment.
nit: could be called EventHandler
raccube
approved these changes
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166
To explain some of the changes:
utilities/instead.$.onsubstitute in vanilla JS, mainly for the use case of global event listeners, which are used plenty in Retrospring, this will make further porting easier.initUserlistens on isDOMContentLoadedand notturbolinks:load. Why? Don't need to set up global event handlers on every turbolinks navigation, once is enough for page scope.To test this PR properly: