Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual share links to answerboxes #232

Merged
merged 12 commits into from
Dec 26, 2021
Merged

Add manual share links to answerboxes #232

merged 12 commits into from
Dec 26, 2021

Conversation

pixeldesu
Copy link
Member

@pixeldesu pixeldesu commented Dec 26, 2021

This is mainly there to "circumvent" the issue with automated sharing, offering links to the share widgets of Twitter and Tumblr.

Also moves the general text preparation into own SocialHelper:: modules, so that it can be reused without duplicating code. Also added tests for all new things!

Also fixes the bug with the OS share menus which only worked on the initial set of answers, that now works on all of them.

@codecov
Copy link

codecov bot commented Dec 26, 2021

Codecov Report

Merging #232 (453724b) into master (2d776e7) will increase coverage by 0.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   61.08%   61.64%   +0.55%     
==========================================
  Files          89       92       +3     
  Lines        2092     2109      +17     
==========================================
+ Hits         1278     1300      +22     
+ Misses        814      809       -5     
Impacted Files Coverage Δ
app/helpers/social_helper.rb 100.00% <100.00%> (ø)
app/helpers/social_helper/tumblr_methods.rb 100.00% <100.00%> (ø)
app/helpers/social_helper/twitter_methods.rb 100.00% <100.00%> (ø)
app/models/services/tumblr.rb 58.33% <100.00%> (+13.88%) ⬆️
app/models/services/twitter.rb 92.30% <100.00%> (-4.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d776e7...453724b. Read the comment docs.

...not just the initially loaded set
@pixeldesu pixeldesu marked this pull request as ready for review December 26, 2021 22:06
app/helpers/social_helper/tumblr_methods.rb Outdated Show resolved Hide resolved
pixeldesu and others added 2 commits December 26, 2021 23:41
Co-authored-by: Karina Kwiatek <6197148+raccube@users.noreply.github.com>
@raccube raccube merged commit 1ba99af into master Dec 26, 2021
@raccube raccube deleted the feature/sharing branch December 26, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants