-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manual share links to answerboxes #232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It badly trips up things
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
+ Coverage 61.08% 61.64% +0.55%
==========================================
Files 89 92 +3
Lines 2092 2109 +17
==========================================
+ Hits 1278 1300 +22
+ Misses 814 809 -5
Continue to review full report at Codecov.
|
...not just the initially loaded set
raccube
approved these changes
Dec 26, 2021
Co-authored-by: Karina Kwiatek <6197148+raccube@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly there to "circumvent" the issue with automated sharing, offering links to the share widgets of Twitter and Tumblr.
Also moves the general text preparation into own
SocialHelper::
modules, so that it can be reused without duplicating code. Also added tests for all new things!Also fixes the bug with the OS share menus which only worked on the initial set of answers, that now works on all of them.