Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch common ShareWorker exceptions to avoid unnecessary retries #238

Merged
merged 7 commits into from
Dec 28, 2021

Conversation

raccube
Copy link
Contributor

@raccube raccube commented Dec 27, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #238 (a534dd0) into master (b544145) will increase coverage by 0.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   61.84%   62.24%   +0.39%     
==========================================
  Files          92       92              
  Lines        2110     2116       +6     
==========================================
+ Hits         1305     1317      +12     
+ Misses        805      799       -6     
Impacted Files Coverage Δ
app/workers/share_worker.rb 100.00% <100.00%> (+60.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b544145...a534dd0. Read the comment docs.

@raccube raccube merged commit fe6a04c into master Dec 28, 2021
@raccube raccube deleted the fix/failed-posts branch December 28, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants