Port List functionality to TypeScript #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(this was broken in prod since this was introduced, amazing!)
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
=======================================
Coverage 62.32% 62.32%
=======================================
Files 92 92
Lines 2121 2121
=======================================
Hits 1322 1322
Misses 799 799 Continue to review full report at Codecov.
|
raccube
reviewed
Dec 30, 2021
| } | ||
|
|
||
| export function createListInputHandler(event: KeyboardEvent): void { | ||
| if (event.which === 13) { |
There was a problem hiding this comment.
A comment of what key this is would be nice
raccube
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163
Should be straightforward to test, just create/delete a list and add/remove a member.
Also fixed a missing translation, that always was here, but never actually set!