Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eager load relationships for questions, answers and users #250

Merged
merged 6 commits into from
Dec 31, 2021

Conversation

raccube
Copy link
Contributor

@raccube raccube commented Dec 30, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #250 (817c221) into master (5552f04) will increase coverage by 2.57%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
+ Coverage   62.32%   64.90%   +2.57%     
==========================================
  Files          92       92              
  Lines        2121     2117       -4     
==========================================
+ Hits         1322     1374      +52     
+ Misses        799      743      -56     
Impacted Files Coverage Δ
app/controllers/discover_controller.rb 0.00% <0.00%> (ø)
app/models/user/answer_methods.rb 100.00% <ø> (+20.00%) ⬆️
app/controllers/answer_controller.rb 86.66% <100.00%> (+86.66%) ⬆️
app/controllers/user_controller.rb 73.60% <100.00%> (+27.99%) ⬆️
app/models/user/relationship_methods.rb 100.00% <100.00%> (+25.00%) ⬆️
app/models/user/timeline_methods.rb 100.00% <100.00%> (ø)
app/models/user/question_methods.rb 100.00% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5552f04...817c221. Read the comment docs.

@raccube raccube merged commit 2a2bd6a into master Dec 31, 2021
@raccube raccube deleted the eager-loading branch December 31, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants