Improve error messaging when trying to attach a service connected to another account #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
==========================================
+ Coverage 66.99% 68.42% +1.42%
==========================================
Files 94 94
Lines 2136 2128 -8
==========================================
+ Hits 1431 1456 +25
+ Misses 705 672 -33
Continue to review full report at Codecov.
|
nilsding
requested changes
Jan 1, 2022
| if service.errors.details.has_key?(:uid) && service.errors.details[:uid].any? { |err| err[:error] == :taken } | ||
| flash[:error] = "The #{service.type.split('::').last.titleize} account you are trying to connect is already connected to another #{APP_CONFIG['site_name']} account." | ||
| else | ||
| flash[:error] = t('flash.service.create.error') + service.errors.inspect |
There was a problem hiding this comment.
Suggested change
| flash[:error] = t('flash.service.create.error') + service.errors.inspect | |
| flash[:error] = t('flash.service.create.error') |
raccube
force-pushed
the
service-attach-errors
branch
from
bd586d5
to
5a597fc
Compare
nilsding
approved these changes
Jan 1, 2022
Co-authored-by: Georg Gadinger <nilsding@nilsding.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #209