Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move turbolinks progressbar to the bottom on tablet and lower #260

Merged
merged 4 commits into from
Jan 1, 2022

Conversation

pixeldesu
Copy link
Member

Fixes #215

(the !important are required because Turbolinks injects it's own style tag and there's no easier way overriding it's styling)

@pixeldesu pixeldesu requested a review from raccube January 1, 2022 19:08
@codecov
Copy link

codecov bot commented Jan 1, 2022

Codecov Report

Merging #260 (b1fa794) into master (5ffce61) will increase coverage by 1.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   66.99%   68.42%   +1.42%     
==========================================
  Files          94       94              
  Lines        2136     2128       -8     
==========================================
+ Hits         1431     1456      +25     
+ Misses        705      672      -33     
Impacted Files Coverage Δ
app/models/service.rb 88.88% <0.00%> (+27.77%) ⬆️
app/controllers/services_controller.rb 66.66% <0.00%> (+66.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ffce61...b1fa794. Read the comment docs.

@raccube
Copy link
Contributor

raccube commented Jan 1, 2022

Actually just tried it on tablet and it's still at the top

@raccube
Copy link
Contributor

raccube commented Jan 1, 2022

Thought: bottom: calc(45px + env(safe-area-inset-bottom)) looks pretty good

@pixeldesu pixeldesu merged commit 2ce9489 into master Jan 1, 2022
@pixeldesu pixeldesu deleted the bugfix/nprogress branch January 1, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NProgress colour isn’t visible at mobile size
2 participants