Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Moderation functionality to TypeScript #285

Merged
merged 15 commits into from
Jan 8, 2022

Conversation

pixeldesu
Copy link
Member

Fixes #162

Testing:

  • (Un)set user privileges
  • (Un)ban a user
  • Moderation Panel:
    • (Un)vote on reports
    • Unfold comment section
    • Comment a report
    • Character count
    • Deleting a comment
    • Deleting a report

As it was mainly used in moderation-heavy areas before, I removed tempusdominus-bootstrap as well, as it just broke making announcements. And subsequently I was able to get rid of the entire legacy-moderation script entrypoint.

It doesn't really matter (right now) to offload that script portion only to moderations as all endpoints are warden-secured in config/routes.rb anyway.

(Report dialog can't be ported yet as Answerbox still requires that in CoffeeScript)

@pixeldesu pixeldesu requested a review from raccube January 8, 2022 02:08
@codecov
Copy link

codecov bot commented Jan 8, 2022

Codecov Report

Merging #285 (8d0ab9a) into master (f80d189) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   69.18%   69.33%   +0.14%     
==========================================
  Files         101      101              
  Lines        2259     2270      +11     
==========================================
+ Hits         1563     1574      +11     
  Misses        696      696              
Impacted Files Coverage Δ
app/helpers/social_helper/twitter_methods.rb 100.00% <0.00%> (ø)
app/models/service.rb 89.47% <0.00%> (+0.58%) ⬆️
app/controllers/services_controller.rb 72.97% <0.00%> (+6.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f80d189...8d0ab9a. Read the comment docs.

@raccube
Copy link
Contributor

raccube commented Jan 8, 2022

image
When following a user

Co-authored-by: Karina Kwiatek <6197148+raccube@users.noreply.github.com>
@pixeldesu
Copy link
Member Author

image When following a user

@raccube Following wasn't touched at all in this?

Rebuild my JS and following works fine, where did you try that, and what does the console say?

@raccube
Copy link
Contributor

raccube commented Jan 8, 2022

Ignore that - was my bad

@pixeldesu pixeldesu merged commit 0868230 into master Jan 8, 2022
@pixeldesu pixeldesu deleted the refactor/typescript-moderation branch January 8, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port Moderation functionality to TypeScript
2 participants