-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Moderation functionality to TypeScript #285
Conversation
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 69.18% 69.33% +0.14%
==========================================
Files 101 101
Lines 2259 2270 +11
==========================================
+ Hits 1563 1574 +11
Misses 696 696
Continue to review full report at Codecov.
|
Co-authored-by: Karina Kwiatek <6197148+raccube@users.noreply.github.com>
@raccube Following wasn't touched at all in this? Rebuild my JS and following works fine, where did you try that, and what does the console say? |
Ignore that - was my bad |
Fixes #162
Testing:
As it was mainly used in moderation-heavy areas before, I removed
tempusdominus-bootstrap
as well, as it just broke making announcements. And subsequently I was able to get rid of the entirelegacy-moderation
script entrypoint.It doesn't really matter (right now) to offload that script portion only to moderations as all endpoints are warden-secured in
config/routes.rb
anyway.(Report dialog can't be ported yet as Answerbox still requires that in CoffeeScript)