Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Webpacker for all assets #295

Merged
merged 11 commits into from
Jan 11, 2022
Merged

Use Webpacker for all assets #295

merged 11 commits into from
Jan 11, 2022

Conversation

pixeldesu
Copy link
Member

This pretty much moves all SCSS into Webpacker so that it doesn't require asset gems and alike anymore.

Also:

  • removed nprogress as it was unused
  • moved font-awesome from an asset gem to an npm package
  • included Lato font locally, not from Google Fonts (Fixes Serve webfont ourselves #95)
  • moved the CSS imports in JS to SCSS
  • removed all the (now) unused asset gems

@pixeldesu pixeldesu requested review from raccube and removed request for nilsding January 11, 2022 20:57
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #295 (562abbf) into master (29923fa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   70.74%   70.74%           
=======================================
  Files         104      104           
  Lines        2287     2287           
=======================================
  Hits         1618     1618           
  Misses        669      669           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29923fa...562abbf. Read the comment docs.

Copy link
Contributor

@raccube raccube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@raccube raccube merged commit 55417ec into master Jan 11, 2022
@raccube raccube deleted the refactor/sasspacker branch January 11, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serve webfont ourselves
2 participants