Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to invert the mouse movement when moving the map #1553

Merged
merged 10 commits into from Sep 5, 2023
Merged

Add option to invert the mouse movement when moving the map #1553

merged 10 commits into from Sep 5, 2023

Conversation

Flamefire
Copy link
Member

@Flamefire Flamefire commented Feb 14, 2023 •
edited

Closes #951

@Spikeone Any idea for better naming or description of the option or is that fine?

@Flamefire Flamefire marked this pull request as draft February 14, 2023 18:02
@Flamefire Flamefire mentioned this pull request Feb 14, 2023
Merged
@Spikeone
Copy link
Member

Closes #951

@Spikeone Any idea for better naming or description of the option or is that fine?

The current way is fine, although it might be user friendly to call it "original scrolling" which is off by default since most people seem to prefer another scroll direction. (So for them the controls are inverted already)

@Flamefire
Copy link
Member Author

"original scrolling" which is off by default since most people seem to prefer another scroll direction. (So for them the controls are inverted already)

Well I wanted to keep the spirit that we use the original behavior as the default. And the request was

Ohne invertiertes (rechte) Maustaste-Scrolling ...

So I guess "inverted" has already some notation which we can keep here :)

@Flamefire Flamefire requested a review from Flow86 July 31, 2023 07:19
@Flamefire Flamefire marked this pull request as ready for review July 31, 2023 07:19
falbrechtskirchinger
falbrechtskirchinger reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the wording. The tooltips are downright confusing.

libs/s25main/Settings.cpp Outdated Show resolved Hide resolved
libs/s25main/desktops/dskOptions.cpp Outdated Show resolved Hide resolved
@Flamefire @falbrechtskirchinger
Change label in iwSettings to "Invert Mouse Pan"
abb7e33 
Co-authored-by: Florian Albrechtskirchinger <falbrechtskirchinger@gmail.com>
falbrechtskirchinger
falbrechtskirchinger approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

Only one nitpick: when I wrote "scrolling/panning" I intended for you to pick one or the other matching the label. Both work too, I guess, but I'd have put "panning" first in that case. 🤷‍♂️

@Flamefire
Copy link
Member Author

@Flow86 ?

@Flow86 Flow86 merged commit 217c29e into Return-To-The-Roots:master Sep 5, 2023
12 of 13 checks passed
@Flamefire Flamefire deleted the invert_mouse branch September 5, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spikeone Spikeone Spikeone left review comments

@falbrechtskirchinger falbrechtskirchinger falbrechtskirchinger approved these changes

@Flow86 Flow86 Awaiting requested review from Flow86

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add invert mouse option
4 participants
@Flamefire @Spikeone @falbrechtskirchinger @Flow86