Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support readonly/private fields & properties #46

Merged
merged 3 commits into from
Apr 8, 2019
Merged

Conversation

ReubenBond
Copy link
Owner

Also merges in changes for RPC, since they are pervasive and hopefully harmless.

@ReubenBond
Copy link
Owner Author

/azp run

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #46 into master will increase coverage by 0.85%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #46      +/-   ##
=========================================
+ Coverage   51.45%   52.3%   +0.85%     
=========================================
  Files          71      73       +2     
  Lines        3088    3139      +51     
  Branches      450     456       +6     
=========================================
+ Hits         1589    1642      +53     
+ Misses       1353    1348       -5     
- Partials      146     149       +3
Impacted Files Coverage Δ
src/Hagar.Abstractions/Annotations.cs 0% <0%> (ø) ⬆️
...r/GeneratedCodeHelpers/HagarGeneratedCodeHelper.cs 76% <0%> (-3.17%) ⬇️
src/Hagar/Invocation/Invokable.cs 0% <0%> (ø)
src/Hagar/Buffers/Writer.cs 84.93% <100%> (ø) ⬆️
src/Hagar/Activators/DefaultActivator.cs 100% <100%> (ø) ⬆️
src/Hagar/Configuration/SerializerConfiguration.cs 100% <100%> (ø) ⬆️
src/Hagar/Buffers/Reader.cs 69.35% <70.58%> (ø) ⬆️
src/Hagar/Utilities/FieldAccessor.cs 83.33% <83.33%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 236d5ef...dd24f57. Read the comment docs.

@ReubenBond
Copy link
Owner Author

Should eventually replace with FieldAccessor from dotnet/coreclr#23783

@ReubenBond ReubenBond merged commit 91ca08f into master Apr 8, 2019
@ReubenBond ReubenBond deleted the feature/readonly branch March 20, 2021 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant