Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use real debug view dependencies in magic weather compose #1203

Merged

Conversation

tonidero
Copy link
Contributor

Description

This changes magic weather compose to use the real debug view dependencies instead of pointing to the local version by default.

@tonidero tonidero added the refactor A code change that neither fixes a bug nor adds a feature label Aug 18, 2023
@tonidero tonidero marked this pull request as ready for review August 18, 2023 06:57
@tonidero tonidero requested a review from a team August 18, 2023 06:57
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1203 (6a0799c) into main (7feda65) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1203   +/-   ##
=======================================
  Coverage   85.88%   85.88%           
=======================================
  Files         183      183           
  Lines        6229     6229           
  Branches      905      905           
=======================================
  Hits         5350     5350           
  Misses        534      534           
  Partials      345      345           

@tonidero tonidero merged commit fcf8b2e into main Aug 22, 2023
7 checks passed
@tonidero tonidero deleted the debug-view-magic-weather-compose-use-real-dependencies branch August 22, 2023 17:01
tonidero added a commit that referenced this pull request Aug 24, 2023
**This is an automatic release.**

### Performance Improvements
* Optimize SDK initialization when requests executed before any activity
starts (#1204) via Toni Rico (@tonidero)
* Optimize diagnostics file management (#1194) via Toni Rico (@tonidero)
### Other Changes
* Use real debug view dependencies in magic weather compose (#1203) via
Toni Rico (@tonidero)

---------

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>
Co-authored-by: Toni Rico <toni.rico.diez@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants