Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create paywall tester app #1218

Merged

Conversation

tonidero
Copy link
Contributor

@tonidero tonidero commented Sep 4, 2023

Description

This PR creates a new Paywall tester app in examples/paywall-tester. It also adds some basic initial UI (just the bottom tab) to mimic what we do in iOS.

This app is part of the main project (not a separate project like MagicWeather/MagicWeatherCompose)
Screenshot_20230904_122254

@tonidero tonidero added the test Adding missing tests or correcting existing tests label Sep 4, 2023
@tonidero tonidero marked this pull request as ready for review September 4, 2023 10:25
@tonidero tonidero requested a review from a team September 4, 2023 10:25
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5dae4fd) 85.93% compared to head (dfc9cab) 85.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1218   +/-   ##
=======================================
  Coverage   85.93%   85.93%           
=======================================
  Files         184      184           
  Lines        6269     6269           
  Branches      911      911           
=======================================
  Hits         5387     5387           
  Misses        536      536           
  Partials      346      346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonidero tonidero changed the base branch from main to paywalls September 4, 2023 13:36
@tonidero tonidero changed the base branch from paywalls to main September 4, 2023 13:37
@tonidero tonidero changed the base branch from main to paywalls September 4, 2023 13:37
compose true
}
composeOptions {
kotlinCompilerExtensionVersion '1.4.0-alpha02'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a 1.5.3. IIRC, the Kotlin version is the reason why we are still in 1.4.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, according to https://developer.android.com/jetpack/androidx/releases/compose-kotlin, since we are using kotlin 1.8.0, we need to use 1.4.0-alpha02. We could update to Kotlin 1.8.20 though... It just seems relatively recent. Thoughts on that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah let's keep it and don't introduce more breaking points

@tonidero
Copy link
Contributor Author

tonidero commented Sep 5, 2023

Will merge this for now, can change this later as needed

@tonidero tonidero merged commit e07f94b into paywalls Sep 5, 2023
7 checks passed
@tonidero tonidero deleted the toniricodiez/pwl-221-create-paywall-tester-sample-app-1 branch September 5, 2023 06:42
tonidero added a commit that referenced this pull request Oct 31, 2023
### Description
This PR creates a new `Paywall tester` app in `examples/paywall-tester`.
It also adds some basic initial UI (just the bottom tab) to mimic what
we do in iOS.

This app is part of the main project (not a separate project like
MagicWeather/MagicWeatherCompose)

![Screenshot_20230904_122254](https://github.com/RevenueCat/purchases-android/assets/808417/4e3e36cd-bbe2-41e8-94b7-138e5f441f98)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants