Paywalls: Use coroutines to interact with SDK #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
added
refactor
tonidero
force-pushed
the
toniricodiez/pwl-221-create-paywall-tester-sample-app-3
branch
from
cda6832
to
bba0dc1
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## paywalls #1224 +/- ##
===========================================
Coverage ? 85.25%
===========================================
Files ? 186
Lines ? 6319
Branches ? 911
===========================================
Hits ? 5387
Misses ? 586
Partials ? 346 ☔ View full report in Codecov by Sentry. |
NachoSoto
approved these changes
Sep 6, 2023
Base automatically changed from
toniricodiez/pwl-221-create-paywall-tester-sample-app-3
to
paywalls
September 6, 2023 17:12
tonidero
force-pushed
the
toniricodiez/pwl-221-create-paywall-tester-sample-app-4
branch
from
f120612
to
10d443a
Compare
tonidero
deleted the
toniricodiez/pwl-221-create-paywall-tester-sample-app-4
branch
This was referenced Oct 16, 2023
tonidero
added a commit
that referenced
this pull request
Oct 31, 2023
### Description We can and should be using coroutines to interact with the main SDK. This updates the paywall tester app and the `revenuecatui ` sdk to use the coroutine versions of the SDK methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can and should be using coroutines to interact with the main SDK. This updates the paywall tester app and the
revenuecatuisdk to use the coroutine versions of the SDK methods.