Add configForLocale to PaywallData #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
approved these changes
Sep 7, 2023
| */ | ||
| fun configForLocale(requiredLocale: Locale): LocalizedConfiguration? { | ||
| return localization[requiredLocale.toString()] | ||
| ?: localization.takeIf { (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) }?.let { localization -> |
There was a problem hiding this comment.
Since paywalls like likely have this or higher minVersion, I think this makes sense 👍
There was a problem hiding this comment.
oh actually! I thiknk this is not necessary and it's from previous code that was using languageTag, let me check
| return localization[requiredLocale.toString()] | ||
| ?: localization.takeIf { (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) }?.let { localization -> | ||
| localization.entries.firstOrNull { (localeKey, _) -> | ||
| Locale(localeKey).isO3Language == requiredLocale.isO3Language |
There was a problem hiding this comment.
Hmm is this a typo? Should it be iso3Language? If not, I wonder if we should use the get method, since this looks weird...
There was a problem hiding this comment.
haha I know it looks weird, but it's not a typo. I will use the get method yes
NachoSoto
reviewed
Sep 7, 2023
| * | ||
| * @return [LocalizedConfiguration] for the given [Locale], if found. | ||
| */ | ||
| fun configForLocale(requiredLocale: Locale): LocalizedConfiguration? { |
There was a problem hiding this comment.
👏🏻
I'm guessing tests will come later? 😇
This was referenced Oct 16, 2023
tonidero
pushed a commit
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart of https://github.com/RevenueCat/purchases-ios/blob/paywalls/Sources/Paywalls/PaywallData.swift#L139
Tested passing
Locale("en")andLocale.USTests will come in future PR where I add tests for PaywallData