`Paywalls`: new `TestData` to store fake paywalls #1239

NachoSoto · 2023-09-11T23:15:24Z

This allows us to create previews for each template so we can easily iterate on them.

NachoSoto · 2023-09-11T23:15:51Z

ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/templates/Template2.kt

+@Preview(showBackground = true)
+@Composable
+fun Template2PaywallPreview() {
+    InternalPaywallView(offering = TestData.template2Offering)


This doesn't actually work, and I have no idea why. Preview fails to load:

java.lang.ClassNotFoundException: com.revenuecat.purchases.Package at java.lang.ClassLoader.loadClass at java.lang.ClassLoader.loadClass at java.lang.Class.getDeclaredMethods0 at java.lang.Class.privateGetDeclaredMethods at java.lang.Class.getDeclaredMethods at androidx.compose.ui.tooling.ComposableInvoker.getDeclaredCompatibleMethod ... (ComposableInvoker.kt:54) at androidx.compose.ui.tooling.ComposableInvoker.findComposableMethod(ComposableInvoker.kt:74)

Hmm I checked out this branch and I'm getting:

Which seems to make sense, since we don't have packages with those ids.

I wasn't able to reproduce your issue. Happy to chat today to figure this out!

I fixed the data now so all packages are found. But now I'm running into this from PurchaseButton:

java.lang.IllegalStateException: Error finding activity

tonidero · 2023-09-12T06:51:54Z

ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/templates/Template2.kt

+@Preview(showBackground = true)
+@Composable
+fun Template2PaywallPreview() {
+    InternalPaywallView(offering = TestData.template2Offering)


Hmm I checked out this branch and I'm getting:

Which seems to make sense, since we don't have packages with those ids.

I wasn't able to reproduce your issue. Happy to chat today to figure this out!

ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/templates/Template2.kt

tonidero · 2023-09-12T06:52:28Z

ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/data/TestData.kt

+import com.revenuecat.purchases.paywalls.PaywallData
+import java.net.URL
+
+class TestData {


Same here, we could make this internal

ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/data/TestData.kt

tonidero · 2023-09-12T07:06:53Z

Also, looks like you might need to run detekt to autocorrect some issues, you can just do ./gradlew detektAll in the root of the project to auto-correct most issues

vegaro · 2023-09-13T11:53:14Z

purchases/src/main/kotlin/com/revenuecat/purchases/paywalls/PaywallData.kt

            }?.value
    }

+    private val Locale.languageWithFallback: String


Maybe add a comment mentioning this is to fix testing and previews

vegaro · 2023-09-13T11:54:19Z

...venuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/data/PaywallViewModel.kt

@@ -22,7 +24,7 @@ internal interface PaywallViewModel {
    val state: StateFlow<PaywallViewState>

    fun selectPackage(packageToSelect: Package)
-    fun purchaseSelectedPackage(activity: Activity)
+    fun purchaseSelectedPackage(context: Context)


hmm, I worry about this becuase there's no indication to the developers that this should be a context with an Activity

This is to fix the previews right? 🤔

Yes, it's to fix the previews. Basically, it can't find an activity in the preview context so it fails... Any ideas of how to solve this? I can add a comment to the function so at least we are aware when using this function... And well, this context is usually an activity... I don't think LocalContext.current would return any service context or anything like that afaik.

This allows us to create previews for each template so we can easily iterate on them.

NachoSoto · 2023-09-13T18:49:27Z

@tonidero this should be ready now :)

codecov · 2023-09-13T19:06:37Z

Codecov Report

❗ No coverage uploaded for pull request base (paywalls@c313806). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@             Coverage Diff             @@
##             paywalls    #1239   +/-   ##
===========================================
  Coverage            ?   85.45%           
===========================================
  Files               ?      187           
  Lines               ?     6351           
  Branches            ?      923           
===========================================
  Hits                ?     5427           
  Misses              ?      567           
  Partials            ?      357

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tonidero

Nice job! This will make iterating much faster 💪

tonidero · 2023-09-13T19:46:16Z

ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/data/TestData.kt

+    val images = PaywallData.Configuration.Images(
+        header = "9a17e0a7_1689854430..jpeg",
+        background = "9a17e0a7_1689854342..jpg",
+        icon = "9a17e0a7_1689854430..jpeg",


Is it normal these have two dots?

That was a bug in how the backend was storing these initially (/cc @joshdholtz 😅)
It's since been fixed, but these test images were uploaded early on.

This allows us to create previews for each template so we can easily iterate on them. --------- Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>

NachoSoto added the RevenueCatUI label Sep 11, 2023

NachoSoto requested a review from a team September 11, 2023 23:15

NachoSoto commented Sep 11, 2023

View reviewed changes

tonidero reviewed Sep 12, 2023

View reviewed changes

tonidero force-pushed the use-coil-to-load-images branch from 5373f71 to b2ab8e9 Compare September 12, 2023 07:29

Base automatically changed from use-coil-to-load-images to paywalls September 12, 2023 08:39

NachoSoto force-pushed the nacho/paywalls-test-data branch from 81383cc to e978586 Compare September 12, 2023 23:01

NachoSoto mentioned this pull request Sep 12, 2023

Paywalls: Map data inputs into consumable TemplateConfiguration class #1242

Merged

NachoSoto force-pushed the nacho/paywalls-test-data branch from e978586 to c5feb8f Compare September 12, 2023 23:11

vegaro reviewed Sep 13, 2023

View reviewed changes

Paywalls: new TestData to store fake paywalls

c4018b5

This allows us to create previews for each template so we can easily iterate on them.

NachoSoto force-pushed the nacho/paywalls-test-data branch from 3f01733 to c4018b5 Compare September 13, 2023 17:56

tonidero and others added 4 commits September 13, 2023 20:02

Fix AS rendering issues with locale and activity

20eb44c

Add comments for changes done to make previews work

7376d15

Internal preview

46c0e80

Lint

ff57933

NachoSoto requested review from tonidero and vegaro September 13, 2023 18:49

tonidero approved these changes Sep 13, 2023

View reviewed changes

NachoSoto merged commit 6c3867c into paywalls Sep 13, 2023
7 checks passed

NachoSoto deleted the nacho/paywalls-test-data branch September 13, 2023 20:01

This was referenced Oct 16, 2023

[DO NOT MERGE] Release/7.1.0-beta.1 #1355

Closed

[DO NOT MERGE] Release/7.1.0-beta.2 #1373

Closed

tonidero added a commit that referenced this pull request Oct 31, 2023

Paywalls: new TestData to store fake paywalls (#1239)

fef3425

This allows us to create previews for each template so we can easily iterate on them. --------- Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`Paywalls`: new `TestData` to store fake paywalls #1239

`Paywalls`: new `TestData` to store fake paywalls #1239

NachoSoto commented Sep 11, 2023

NachoSoto Sep 11, 2023

tonidero Sep 12, 2023

NachoSoto Sep 12, 2023

tonidero Sep 12, 2023

tonidero Sep 12, 2023

tonidero commented Sep 12, 2023

vegaro Sep 13, 2023

vegaro Sep 13, 2023

vegaro Sep 13, 2023

tonidero Sep 13, 2023

NachoSoto commented Sep 13, 2023

codecov bot commented Sep 13, 2023

tonidero left a comment

tonidero Sep 13, 2023

NachoSoto Sep 13, 2023

Paywalls: new TestData to store fake paywalls #1239

Paywalls: new TestData to store fake paywalls #1239

Conversation

NachoSoto commented Sep 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tonidero commented Sep 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NachoSoto commented Sep 13, 2023

codecov bot commented Sep 13, 2023

Codecov Report

tonidero left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

`Paywalls`: new `TestData` to store fake paywalls #1239

`Paywalls`: new `TestData` to store fake paywalls #1239