Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update magicweather dependency to 5.0.0-rc1 #456

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Update magicweather dependency to 5.0.0-rc1 #456

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41e08bc
revert magicweather base application changes
vegaro Jan 21, 2022
6624b26
update magicweather dependency version
vegaro Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 18 additions & 2 deletions examples/MagicWeather/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,20 @@
apply from: "$rootProject.projectDir/base-application.gradle"
plugins {
id 'com.android.application'
id 'kotlin-android'
}

android {
compileSdkVersion 29
buildToolsVersion "30.0.3"

defaultConfig {
applicationId "com.revenuecat.purchases_sample"
minSdkVersion 26
targetSdkVersion 29
versionCode 1
versionName "1.0"

testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}

buildTypes {
Expand All @@ -14,10 +23,17 @@ android {
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
}
}
compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}
kotlinOptions {
jvmTarget = '1.8'
}
}

dependencies {
implementation 'com.revenuecat.purchases:purchases:4.0.2'
implementation 'com.revenuecat.purchases:purchases:5.0.0-rc1'
Comment on lines -20 to +36
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to have this as a part of the bump process so we don't forget to update in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! I created a story for it https://app.shortcut.com/revenuecat/story/12669/automatically-increase-version-in-purchases-android-magicweather so we don't forget

implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
implementation 'androidx.core:core-ktx:1.3.2'
implementation 'androidx.appcompat:appcompat:1.2.0'
Expand Down