Added Purchases.logHandler
#492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes [sc-11102]. The default implementation is unchanged, using `android.util.Log`. Users can provide their own implementation of `LogHandler`. ## Other changes: - `errorLog` can now provide an optional `throwable`, which will be forwarded if set - Added tests to verify the handler is used - Removed ad-hoc usage of `Log.e` - Added API to `apitester`
|
This pull request has been linked to Shortcut Story #11102: [Android] Create LogHandler. |
vegaro
approved these changes
Feb 22, 2022
| } | ||
|
|
||
| override fun e(tag: String, msg: String, throwable: Throwable?) { | ||
| if (throwable != null) { |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes [sc-11102].
The default implementation is unchanged, using
android.util.Log.Users can provide their own implementation of
LogHandler.Other changes:
errorLogcan now provide an optionalthrowable, which will be forwarded if setLog.eapitester