CF-241 Amazon is swallowing all exceptions that happen in the listeners

[vegaro]

CF-241

I noticed offerings were not loading. Products were failing to load. There was no exceptions or anything. But after a lot of debugging I found this little gem in Amazon's code:

                     try {
                        if (var1 instanceof ProductDataResponse) {
                            var3.onProductDataResponse((ProductDataResponse)var1);
                        } else if (var1 instanceof UserDataResponse) {
                            var3.onUserDataResponse((UserDataResponse)var1);
                        } else if (var1 instanceof PurchaseUpdatesResponse) {
                            var3.onPurchaseUpdatesResponse((PurchaseUpdatesResponse)var1);
                        } else if (var1 instanceof PurchaseResponse) {
                            var3.onPurchaseResponse((PurchaseResponse)var1);
                        } else {
                            e.b(c.a, "Unknown response type:" + var1.getClass().getName());
                        }
                    } catch (Exception var2) {
                        e.b(c.a, "Error in sendResponse: " + var2);
                    }

They are basically catching all Exceptions that happen in the listener we implemented. I also noticed they display a short log while in App Tester but not when the app is downloaded from Live App Testing.

[beylmk]

is there a common base type for all of the Responses so that we can avoid code duplication?

[vegaro]

no... they are all different and no base class 😭

[beylmk]

yayyy we can finally test logs!

[beylmk]

🧯 looks good, just the one question on code duplication