Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added subscription period and free trial period parsing for Amazon #884

Merged
merged 2 commits into from Mar 20, 2023
Merged

Added subscription period and free trial period parsing for Amazon #884

merged 2 commits into from Mar 20, 2023

Conversation

joshdholtz
Copy link
Contributor

@joshdholtz joshdholtz commented Mar 17, 2023 •
edited by jira bot

Motivation

CF-1288

Description

Parses Amazon's English language period durations into a Period object and an ISO 8601 string 馃挭

@joshdholtz joshdholtz added the feat A new feature label Mar 17, 2023
beylmk
beylmk approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@beylmk beylmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃彺鬆仹鬆仮鬆仴鬆伄鬆仹鬆伩 thank you!

@joshdholtz joshdholtz merged commit b91a6f3 into amazon-store-product Mar 20, 2023
@joshdholtz joshdholtz deleted the amazon-store-product-period branch March 20, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beylmk beylmk beylmk approved these changes

@vegaro vegaro Awaiting requested review from vegaro

Assignees
No one assigned
Labels
feat A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshdholtz @beylmk