Move and rename to new RC official plugin #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
commented
Aug 28, 2023
tonidero
force-pushed
the
revenuecat-base-branch
branch
6 times, most recently
from
b44f47f
to
b1baae5
Compare
tonidero
force-pushed
the
revenuecat-base-branch
branch
from
af0a416
to
cea9ba3
Compare
vegaro
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Should this file be removed?
There was a problem hiding this comment.
Well, it was generated when creating the ionic project... I don't think we will really use cypress for now, so we could probably remove it entirely, but will do that in a separate PR. Removing this file would also require removing other files so I prefer not to do it here.
There was a problem hiding this comment.
Ok! I was asking in case you had commented it out yourself
vegaro
approved these changes
Aug 28, 2023
vegaro
reviewed
Aug 29, 2023
example/purchase-tester/src/components/FunctionTesterContainer.tsx
Outdated
Show resolved
Hide resolved
NachoSoto
reviewed
Aug 31, 2023
| @@ -60,7 +60,7 @@ public class PurchasesPlugin: CAPPlugin, PurchasesDelegate { | |||
| call.keepAlive = true | |||
| self.customerInfoUpdateListeners.append(call.callbackId) | |||
| if let lastReceivedCustomerInfo { | |||
| call.resolve(lastReceivedCustomerInfo.dictionary) | |||
| call.resolve(CommonFunctionality.encode(customerInfo: lastReceivedCustomerInfo)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the changes to the plugin performed by RC from an internal repo to the public repo. There will be a new major release v6.0.0 soon with all the changes. Some of the major changes:
@capgo/capacitor-purchasesto@revenuecat/purchases-capacitor.CapacitorPurchasestoPurchases.migration/v6-MIGRATION.md.