Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to applying Gradle plugins with the declarative plugins block in sample #1062

Merged
merged 1 commit into from
May 6, 2024

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented May 6, 2024

I kept getting

You are applying Flutter's main Gradle plugin imperatively using the apply script method, which is deprecated and will be removed in a future release. Migrate to applying Gradle plugins with the declarative plugins block: https://flutter.dev/go/flutter-gradle-plugin-apply

when running the sample. I created a new plugin project and made some changes over to our purchase tester app

@vegaro vegaro added the refactor A code change that neither fixes a bug nor adds a feature label May 6, 2024
@vegaro vegaro requested a review from a team May 6, 2024 13:19
@RevenueCat-Danger-Bot
Copy link

1 Message
📖 Size increase: 0.90 KB

Generated by 🚫 Danger


import io.flutter.embedding.android.FlutterFragmentActivity

class MainActivity: FlutterFragmentActivity()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migrated this to kotlin since that's the default when creating a new app

Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this!

@vegaro vegaro merged commit edbb5b0 into main May 6, 2024
8 checks passed
@vegaro vegaro deleted the remove-apply-plugin branch May 6, 2024 13:27
tonidero added a commit that referenced this pull request May 16, 2024
**This is an automatic release.**

### Bugfixes
* [EXTERNAL] fix: call presentPaywallIfNeeded when needed (#1066) by
@danjocha (#1069) via Cesar de la Vega (@vegaro)
### Dependency Updates
* [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.6.2 (#1067) via
RevenueCat Git Bot (@RCGitBot)
### Other Changes
* Remove SafeArea in sample in paywall.dart (#1063) via Cesar de la Vega
(@vegaro)
* Migration to applying Gradle plugins with the declarative plugins
block in sample (#1062) via Cesar de la Vega (@vegaro)

---------

Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants