Feature: identity v3 #180

aboedo · 2021-04-01T21:32:46Z

changes summary:

adds logIn and logOut methods
deprecates setAllowSharingAppStoreAccount, identify and reset methods

Requirements:

purchases-hybrid-common release with identity v3 support
purchases-ios release with identity v3 support
purchases-android release with identity v3 support

aboedo · 2021-04-09T15:57:06Z

lib/entitlement_info_wrapper.dart

+  @override
+  bool operator ==(other) {


used for checks in tests

aboedo · 2021-04-09T15:57:30Z

ios/Classes/PurchasesFlutterPlugin.m

@@ -4,55 +4,61 @@

 #import <PurchasesHybridCommon/PurchasesHybridCommon.h>

+


a lot of the stuff in this file is auto-formatting

aboedo · 2021-04-09T15:57:39Z

ios/Classes/PurchasesFlutterPlugin.m

+    } else if ([@"logOut" isEqualToString:call.method]) {
+        [self logOutWithResult:result];
    } else if ([@"reset" isEqualToString:call.method]) {
        [self resetWithResult:result];
+    } else if ([@"logIn" isEqualToString:call.method]) {
+        [self logInAppUserID:arguments[@"appUserID"] result:result];
    } else if ([@"identify" isEqualToString:call.method]) {


new stuff here

aboedo · 2021-04-09T15:58:10Z

ios/Classes/PurchasesFlutterPlugin.m

+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"


these are to prevent xcode build warnings that show up for developers who use our SDK, even if it's internal to us

aboedo · 2021-04-09T15:58:25Z

ios/Classes/PurchasesFlutterPlugin.m

- (void)identify:(NSString *_Nullable)appUserID
-          result:(FlutterResult)result
-{
+- (void)logInAppUserID:(NSString * _Nullable)appUserID


new stuff here

aboedo · 2021-04-09T15:58:33Z

ios/Classes/PurchasesFlutterPlugin.m

+}
+
+- (void)logOutWithResult:(FlutterResult)result {
+    [RCCommonFunctionality logOutWithCompletionBlock:[self getResponseCompletionBlock:result]];


end of new stuff

aboedo · 2021-04-09T15:59:13Z

lib/purchases_flutter.dart

@@ -631,3 +667,16 @@ class IntroEligibility {
      : status = IntroEligibilityStatus.values[map["status"]],
        description = map["description"];
 }
+
+/// Class used to hold the result of the logIn method
+class LogInResult {


didn't know the best way to handle it in Flutter, it seemed like having a new type would be the cleanest.

vegaro

LGTM! Don 't forget to remove all the temporary dependencies stuff

vegaro · 2021-04-09T19:47:40Z

oh just saw purchases-hybrid-common is merged with the temporary dependencies. Is the plan to merge this too and then remove the temporary development dependencies in a future PR?

aboedo · 2021-04-09T19:49:02Z

yeah, that was my thinking, to have everything ready and merged and then in the release branch make sure to point to final versions

…e's dependencies are compatible with null safety

…always storing purchaserInfo

…dling on Android

…m MagicWeather

…other branch in the switch

aboedo · 2021-07-19T19:26:54Z

ios/Classes/PurchasesFlutterPlugin.m

+- (void)canMakePaymentsWithFeatures:(NSArray <NSNumber *>*)features result:(FlutterResult)result {
+    result(@([RCCommonFunctionality canMakePaymentsWithFeatures:features]));
+}
+


not new, just formatted and moved to after collectDeviceIdentifiersWithResult since that one is related to attribution

… the local version, updated calls to identity methods to identity v3 in magicWeather

aboedo added the HOLD label Apr 1, 2021

aboedo self-assigned this Apr 1, 2021

aboedo marked this pull request as draft April 2, 2021 18:04

aboedo force-pushed the feature/identity_v3 branch 2 times, most recently from f3b34a5 to 8fb7d6b Compare April 9, 2021 17:56

aboedo commented Apr 9, 2021

View reviewed changes

aboedo marked this pull request as ready for review April 9, 2021 18:23

aboedo requested review from vegaro and beylmk April 9, 2021 18:24

vegaro approved these changes Apr 9, 2021

View reviewed changes

aboedo added 17 commits July 19, 2021 16:08

added logIn and logOut methods

7232e30

added deprecation warnings

4e3b88d

bump minimum sdk version in example

8573b88

downgraded minimum sdk version in example since not all of the exampl…

6cac444

…e's dependencies are compatible with null safety

added logIn and logOut methods for iOS

76e1580

update formatting in PurchasesFlutterPlugin.m

cd19b25

improved LogInResult class

d6662f3

rename purchaserInfoDictionary -> resultDictionary because it wasn't …

3fe4474

…always storing purchaserInfo

suppressed deprecation warnings for internal calls

59a0409

added login and logOut methods on android

2e45740

updated pod dependencies on iOS to use a git branch

5628ce4

updated login calls on iOS for new naming, added login and logout han…

3da434f

…dling on Android

added logIn and logOut tests

1a6e461

updated purchases-hybrid-common pointer to develop for iOS as well

bca50ee

updated Podfile for testing for purchaseTester, removed test pods fro…

5ed88fe

…m MagicWeather

fixed compilation error because the variable name had been used in an…

b572e98

…other branch in the switch

updated version number to 1.8.0

0b3950f

aboedo force-pushed the feature/identity_v3 branch from 122a3af to 0b3950f Compare July 19, 2021 19:23

aboedo removed the HOLD label Jul 19, 2021

aboedo commented Jul 19, 2021

View reviewed changes

aboedo added 2 commits July 19, 2021 16:28

fixed duplicate import in test file

c6031b2

updated the pointer to purchases_flutter for MagicWeather to point to…

d440ddd

… the local version, updated calls to identity methods to identity v3 in magicWeather

aboedo force-pushed the feature/identity_v3 branch from 5f1d873 to d440ddd Compare July 19, 2021 19:47

aboedo added 2 commits July 19, 2021 16:54

silenced deprecation warning for internal call to createAlias

8d11e42

updated call to reset -> logOut in MagicWeather

b168812

aboedo merged commit 2c28956 into develop Jul 19, 2021

aboedo deleted the feature/identity_v3 branch July 19, 2021 20:10

aboedo mentioned this pull request Jul 19, 2021

Release: 3.4.0 #218

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: identity v3 #180

Feature: identity v3 #180

aboedo commented Apr 1, 2021 •

edited

aboedo Apr 9, 2021

aboedo Apr 9, 2021

aboedo Apr 9, 2021

aboedo Apr 9, 2021

aboedo Apr 9, 2021

aboedo Apr 9, 2021

aboedo Apr 9, 2021

vegaro left a comment

vegaro commented Apr 9, 2021

aboedo commented Apr 9, 2021

aboedo Jul 19, 2021

		@@ -4,55 +4,61 @@

		#import <PurchasesHybridCommon/PurchasesHybridCommon.h>

		#pragma GCC diagnostic push
		#pragma GCC diagnostic ignored "-Wdeprecated-declarations"

Feature: identity v3 #180

Feature: identity v3 #180

Conversation

aboedo commented Apr 1, 2021 • edited

changes summary:

Requirements:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vegaro left a comment

Choose a reason for hiding this comment

vegaro commented Apr 9, 2021

aboedo commented Apr 9, 2021

Choose a reason for hiding this comment

aboedo commented Apr 1, 2021 •

edited