Add ownershipType to entitlementInfo #278
Conversation
CHANGELOG.md
Outdated
| @@ -1,3 +1,5 @@ | |||
| - Adds ownershipType to the EntitlementInfo wrapper | |||
|
|
|||
There was a problem hiding this comment.
Thanks for adding this here. We can take care of the Changelog when releasing the newer version, so no need to add this in the Changelog for now 😄
lib/entitlement_info_wrapper.dart
Outdated
| case "PURCHASED": | ||
| ownershipType = OwnershipType.purchased; | ||
| break; | ||
| case "FAMILY_SHARING": |
There was a problem hiding this comment.
This should be FAMILY_SHARED as commented in the android PR
lib/entitlement_info_wrapper.dart
Outdated
| purchased, | ||
|
|
||
| /// For ownership when a user has been shared the purchase via family sharing | ||
| familySharing, |
There was a problem hiding this comment.
This should be familyShared
| /// Enum of ownership types | ||
| enum OwnershipType { | ||
| /// For ownership when a user made the purchase themselves | ||
| purchased, |
There was a problem hiding this comment.
These docs look great, but maybe we can reuse the docs in the iOS enum? https://github.com/RevenueCat/purchases-ios/blob/main/Purchases/Public/PurchaseOwnershipType.swift#L20
There was a problem hiding this comment.
Used the iOS docs and also updated the purchases-android ones to match. I included the UNKNOWN because it looks like the linter wants all public fields documented.
| entitlementInfo = EntitlementInfo.fromJson(entitlementInfoJson); | ||
|
|
||
| expect(entitlementInfo.ownershipType, OwnershipType.unknown); | ||
| }); |
There was a problem hiding this comment.
Amazing! Thanks so much for writing tests!
|
Thank you @daentech! |
Description:
This PR exposes
ownershipTypeonEntitlementInfoas, while it had been added topurchases-hybrid-common, it was unavailable in the flutter SDK itself.purchases-androidPR: RevenueCat/purchases-android#382purchases-hybrid-commonPR: RevenueCat/purchases-hybrid-common#103Related to Zendesk ticket: 12668