Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: freezed intro pricing crash #294

Merged
merged 2 commits into from Jan 17, 2022
Merged

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Jan 14, 2022

Fixes #293

Bumps to purchases-hybrid-common 1.11.2, which fixes an inconsistency in the way that null introPrices were rendered to JSON

@aboedo aboedo requested a review from a team January 14, 2022 20:37
@aboedo aboedo self-assigned this Jan 14, 2022
version '3.7.1'
version '3.9.1'
Copy link
Member Author

@aboedo aboedo Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

This doesn't affect anything, though, since the dependency is set up locally.

@@ -4,6 +4,8 @@
https://github.com/RevenueCat/purchases-flutter/pull/285
- Removed all references to JCenter (More on the [JCenter Shutdown](https://blog.gradle.org/jcenter-shutdown))
https://github.com/RevenueCat/purchases-flutter/pull/285
- Updated JSON serialization using Freezed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be under a new section?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was missing from the 3.9.0 changelog, but it was a part of that release

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah okay, think i got confused because this PR does some of the releasing steps? you're going to do a different PR for the release though?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol yeah, I guess I got a bit ahead of myself and updated some files prematurely. I'm going to make a different PR for the release 👍

Copy link
Contributor

@taquitos taquitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants