expose originalPurchaseDate in RCPurchaserInfo #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding tests for this is pretty tricky because we have to create a whole bunch of mocks. I'd like to improve our testing game, but I also don't want to delay this any further, since we've had it in the backlog for a while. |
vegaro
reviewed
May 28, 2020
| } else { | ||
| return NSNull.null; | ||
| } | ||
| } |
There was a problem hiding this comment.
Should we move these two to NSDate+HybridAdditions.h?
There was a problem hiding this comment.
that wouldn't work, unfortunately, because if the date is nil the func will no-op. it could be a static method, but I'm not sure it would add much value
vegaro
approved these changes
May 28, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added originalPurchaseDate to RCPurchaserInfo dict