Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equality comparison instead of assignment #35

Closed
keleftheriou opened this issue Jun 21, 2018 · 1 comment
Closed

Equality comparison instead of assignment #35

keleftheriou opened this issue Jun 21, 2018 · 1 comment

Comments

@keleftheriou
Copy link
Contributor

I'm not exactly sure when/how this can cause undesired behavior, but it should be a single equals:

if (self == [super init]) {

@jeiting
Copy link
Contributor

jeiting commented Jun 23, 2018

🤦‍♂️

Ough. Good catch. Shouldn't cause any issues, the tests would catch it. This is what I get for being a cranky old Obj-C guy.

jeiting added a commit that referenced this issue Jul 3, 2018
@jeiting jeiting closed this as completed Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants