v4: Fix .xcframework not including dSYMs #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😍 awesome nice find! For the record, Carthage/Carthage#3235 does this automatically too :P |
NachoSoto
approved these changes
Dec 29, 2021
Awesome!! ❤️ |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V4 equivalent of #1117
Related community post here
Our
.xcframeworkfolder didn't include .dSYMs. This could be a problem depending on the package manager being used. In particular, for Carthage, when usingcarthage update --use-xcframeworks, the.xcframeworkthat got pulled in and built would never have thedSYMs. Only workaround would be to copy them from the checkouts folder.The plugin that we're using has an
include_debug_symbolparameter that defaults totrue, if omitted, it doesn't work.I've filed an issue and a PR with a fix, but in the meantime, we can pass the parameter in to fix the issue on our side.
Note: I'm making the PR against
release/3.13.1so that if we release another hotfix, we can branch off of that one and have the.xcframeworkfile fixed.