Improve the way to handle the error if purchase(sk2Product) fails due to an error when posting the receipt
#1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juanpe
commented
Jan 14, 2022
| @@ -215,7 +243,7 @@ class PurchasesOrchestratorTests: StoreKitConfigTestCase { | |||
| expect(self.backend.invokedPostReceiptDataParameters?.isRestore).to(beFalse()) | |||
| } | |||
|
|
|||
| func testStoreKit2TransactionListenerDelegateWithObesrverMode() async throws { | |||
| func testStoreKit2TransactionListenerDelegateWithObserverMode() async throws { | |||
NachoSoto
reviewed
Jan 14, 2022
| expect(userCancelled) == false | ||
| expect(customerInfo).to(beNil()) | ||
| expect(error).toNot(beNil()) | ||
| expect(error?.localizedDescription).to(equal(expectedError.localizedDescription)) |
There was a problem hiding this comment.
Maybe check the domain and code too?
There was a problem hiding this comment.
It makes sense.
Finally, I used the matchError, a predicate provided by Nimble to compare errors. Both the code and the domain are internally validated 👍🏼
Juanpe
deleted the
purchase_package_check_if_thrown_error_is_StoreKitError
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-androidand hybridsMotivation
Resolves #1114
Now, if
purchase(sk2Product:)fails because of an error when posting the receipt, the method returnsErrorCode.unknownErrorbecause it assumes it always receives aStoreKitError. The goal of this PR is to improve the way to handle the error.Description
wherecondition to know if the error type isStoreKitError, if not the method returns the error received.