Release/3.14.1 #1264
Merged
Release/3.14.1 #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efreshes the receipt
NachoSoto
reviewed
Feb 7, 2022
Purchases/Public/RCPurchases.h
Outdated
| @@ -382,7 +382,7 @@ NS_SWIFT_NAME(syncPurchases(_:)); | |||
| /** | |||
| Computes whether or not a user is eligible for the introductory pricing period of a given product. You should use this method to determine whether or not you show the user the normal product price or the introductory price. This also applies to trials (trials are considered a type of introductory pricing). | |||
|
|
|||
| @note Subscription groups are automatically collected for determining eligibility. If RevenueCat can't definitively compute the eligibilty, most likely because of missing group information, it will return `RCIntroEligibilityStatusUnknown`. The best course of action on unknown status is to display the non-intro pricing, to not create a misleading situation. To avoid this, make sure you are testing with the latest version of iOS so that the subscription group can be collected by the SDK. | |||
| @note Subscription groups are automatically collected for determining eligibility. If RevenueCat can't definitively compute the eligiibilty, most likely because of missing group information, it will return `RCIntroEligibilityStatusUnknown`. The best course of action on unknown status is to display the non-intro pricing, to not create a misleading situation. To avoid this, make sure you are testing with the latest version of iOS so that the subscription group can be collected by the SDK. | |||
There was a problem hiding this comment.
LOL I went to fix it and I made it worse
NachoSoto
reviewed
Feb 7, 2022
| expect(self.requestFetcher.refreshReceiptCalled) == false | ||
| expect(self.receiptFetcher.receiptDataCalled) == false | ||
|
|
||
| purchases!.checkTrialOrIntroductoryPriceEligibility([]) { (eligibilities) in |
There was a problem hiding this comment.
The ! isn't required right? It's already an implicitly unwrapped optional.
There was a problem hiding this comment.
great catch!! I was mislead because we're actually treating purchases as a regular optional everywhere in this file. I updated all references, since that's not necessary
…onal `Purchases` as a regular optional
|
This is the first step toward fixing RevenueCat/react-native-purchases#328. |
taquitos
reviewed
Feb 7, 2022
| @@ -382,7 +382,7 @@ NS_SWIFT_NAME(syncPurchases(_:)); | |||
| /** | |||
| Computes whether or not a user is eligible for the introductory pricing period of a given product. You should use this method to determine whether or not you show the user the normal product price or the introductory price. This also applies to trials (trials are considered a type of introductory pricing). | |||
|
|
|||
| @note Subscription groups are automatically collected for determining eligibility. If RevenueCat can't definitively compute the eligibilty, most likely because of missing group information, it will return `RCIntroEligibilityStatusUnknown`. The best course of action on unknown status is to display the non-intro pricing, to not create a misleading situation. To avoid this, make sure you are testing with the latest version of iOS so that the subscription group can be collected by the SDK. | |||
| @note Subscription groups are automatically collected for determining eligibility. If RevenueCat can't definitively compute the eligibility, most likely because of missing group information, it will return `RCIntroEligibilityStatusUnknown`. The best course of action on unknown status is to display the non-intro pricing, to not create a misleading situation. To avoid this, make sure you are testing with the latest version of iOS so that the subscription group can be collected by the SDK. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkTrialOrIntroductoryPriceEligibilitymight refresh the receipt if it's not present on device, causing a log in prompt for App Store credentials.Release/3.14.1 #1264