Offering: improved confusing log for PackageType.custom
#1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes [CSDK-450]. We were logging a message for packages with custom duration that says "Unknown subscription length for package, ignoring." This is very confusing for customers, as it looks like something is wrong. However it’s expected and normal behavior for packages with custom duration.
NachoSoto
commented
Sep 5, 2022
| @@ -138,11 +139,13 @@ import Foundation | |||
| case .custom where package.storeProduct.productCategory == .nonSubscription: | |||
| // Non-subscription product, ignoring | |||
There was a problem hiding this comment.
I still left this extra case because it doesn't even warrant a log.
tonidero
approved these changes
Sep 6, 2022
| @@ -109,6 +109,7 @@ import Foundation | |||
| return package(identifier: key) | |||
| } | |||
|
|
|||
| // swiftlint:disable:next cyclomatic_complexity | |||
There was a problem hiding this comment.
Hmm might be good to try to refactor this to avoid this issue... But NABD.
There was a problem hiding this comment.
Yeah I thought about it but this needs to be in init in order to make the type immutable so I couldn't think of how to extract it out. Ultimately it's just a factor of the number of cases and putting a limit to that is kind of arbitrary.
| @@ -38,6 +38,8 @@ enum OfferingStrings { | |||
| case configuration_error_no_products_for_offering | |||
| case offering_empty(offeringIdentifier: String) | |||
| case product_details_empty_title(productIdentifier: String) | |||
| case unknown_package_type(Package) | |||
| case custom_package_type(Package) | |||
There was a problem hiding this comment.
I see the cases above have a parameter name in addition to the type. Is that ok? And if so, it might be a good idea to consolidate them.
There was a problem hiding this comment.
It's useful for parameters like Strings because it's not clear what they contain. But a package is always going to be a package 😅
NachoSoto
pushed a commit
that referenced
this pull request
Sep 8, 2022
**This is an automatic release.** ### Bugfixes * `watchOS`: fixed crash when ran on single-target apps with Xcode 14 and before `watchOS 9.0` (#1895) via NachoSoto (@NachoSoto) * `CustomerInfoManager`/`OfferingsManager`: improved display of underlying errors (#1888) via NachoSoto (@NachoSoto) * `Offering`: improved confusing log for `PackageType.custom` (#1884) via NachoSoto (@NachoSoto) * `PurchasesOrchestrator`: don't log warning if `allowSharingAppStoreAccount` setting was never explicitly set (#1885) via NachoSoto (@NachoSoto) * Introduced type-safe `PurchasesError` and fixed some incorrect returned error types (#1879) via NachoSoto (@NachoSoto) * `CustomerInfoManager`: fixed thread-unsafe implementation (#1878) via NachoSoto (@NachoSoto) ### New Features * Disable SK1's `StoreKitWrapper` if SK2 is enabled and available (#1882) via NachoSoto (@NachoSoto) * `Sendable` support (#1795) via NachoSoto (@NachoSoto) ### Other Changes * Renamed `StoreKitWrapper` to `StoreKit1Wrapper` (#1886) via NachoSoto (@NachoSoto) * Enabled `DEAD_CODE_STRIPPING` (#1887) via NachoSoto (@NachoSoto) * `HTTPClient`: added `X-Client-Bundle-ID` and logged on SDK initialization (#1883) via NachoSoto (@NachoSoto) * add link to SDK reference (#1872) via Andy Boedo (@aboedo) * Added `StoreKit2Setting.shouldOnlyUseStoreKit2` (#1881) via NachoSoto (@NachoSoto) * Introduced `TestLogHandler` to simplify how we test logged messages (#1858) via NachoSoto (@NachoSoto) * `Integration Tests`: added test for purchasing `StoreProduct` instead of `Package` (#1875) via NachoSoto (@NachoSoto) * `ErrorUtils`: added test to verify that returned errors can be converted to `ErrorCode` (#1871) via NachoSoto (@NachoSoto)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CSDK-450.
We were logging a message for packages with custom duration that says "Unknown subscription length for package, ignoring."
This is very confusing for customers, as it looks like something is wrong. However it’s expected and normal behavior for packages with custom duration.