Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy PurchaseTesterSwiftUI to TestFlight #2003

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented Oct 26, 2022

Fixes CSDK-510.

IMG_495339BA4A2F-1

Depends on #1999.

Also set up CI as per the docs:
Added these 2 environment variables:

  • SPACESHIP_ONLY_ALLOW_INTERACTIVE_2FA
  • FASTLANE_SESSION

@NachoSoto NachoSoto added WIP ci Changes to our CI configuration files and scripts labels Oct 26, 2022
@NachoSoto NachoSoto force-pushed the purchase-tester-testflight branch 12 times, most recently from 3402f75 to ce4e7ba Compare October 27, 2022 18:44
@NachoSoto NachoSoto requested a review from a team October 27, 2022 18:51
@NachoSoto NachoSoto marked this pull request as ready for review October 27, 2022 20:43
@NachoSoto NachoSoto removed the WIP label Oct 27, 2022
@NachoSoto
Copy link
Contributor Author

This is ready 🎉

@NachoSoto NachoSoto changed the title Deploy Purchase Tester to TestFlight Deploy PurchaseTesterSwiftUI to TestFlight Oct 27, 2022
@NachoSoto
Copy link
Contributor Author

I'm going to submit a catalyst version too

Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

lane :deploy_purchase_tester do
match(verbose: true, readonly: true)
increment_build_number(
build_number: latest_testflight_build_number + 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using the CircleCI build number here, but then, this is probably fine as well 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the latest Xcode versions were supposed to auto-bump build numbers?
But then again, that might be only if you use Xcode, not if you go through command line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah and I use that for my own app now, but it wasn't working without bumping the build number manually like this. So they probably built that feature into the UI only (like when Swift shipped 😂)

@@ -0,0 +1 @@
import("../../../../fastlane/Fastfile")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this I guess the PurchaseTesterSwiftUI project will have access to all the project fastfile's functions... There are probably many that shouldn't be called from here, but then again, I think it should be ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's fine. It's the same approach we use in the installation tests.

@@ -0,0 +1,6 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the icon is glorious 🎨

lane :deploy_purchase_tester do
match(verbose: true, readonly: true)
increment_build_number(
build_number: latest_testflight_build_number + 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the latest Xcode versions were supposed to auto-bump build numbers?
But then again, that might be only if you use Xcode, not if you go through command line

Base automatically changed from purchase-tester-api-key-2 to main November 3, 2022 21:44
@NachoSoto NachoSoto merged commit 4189aa1 into main Nov 3, 2022
@NachoSoto NachoSoto deleted the purchase-tester-testflight branch November 3, 2022 21:48
NachoSoto pushed a commit that referenced this pull request Nov 9, 2022
**This is an automatic release.**

### Bugfixes
* `ISO8601DateFormatter.withMilliseconds`: fixed iOS 11 crash (#2037)
via NachoSoto (@NachoSoto)
* Changed `StoreKit2Setting.default` back to
`.enabledOnlyForOptimizations` (#2022) via NachoSoto (@NachoSoto)
### Other Changes
* `Integration Tests`: changed weekly to monthly subscriptions to work
around 0-second subscriptions (#2042) via NachoSoto (@NachoSoto)
* `Integration Tests`: fixed `testPurchaseWithAskToBuyPostsReceipt`
(#2040) via NachoSoto (@NachoSoto)
* `ReceiptRefreshPolicy.retryUntilProductIsFound`: default to returning
"invalid" receipt (#2024) via NachoSoto (@NachoSoto)
* `CachingProductsManager`: use partial cached products (#2014) via
NachoSoto (@NachoSoto)
* Added `BackendErrorCode.purchasedProductMissingInAppleReceipt` (#2033)
via NachoSoto (@NachoSoto)
* `PurchaseTesterSwiftUI`: replaced `Purchases` dependency with `SPM`
(#2027) via NachoSoto (@NachoSoto)
* `Integration Tests`: changed log output to `raw` (#2031) via NachoSoto
(@NachoSoto)
* `Integration Tests`: run on iOS 16 (#2035) via NachoSoto (@NachoSoto)
* CI: fixed `iOS 14` tests Xcode version (#2030) via NachoSoto
(@NachoSoto)
* `Async.call`: added non-throwing overload (#2006) via NachoSoto
(@NachoSoto)
* Documentation: Fixed references in `V4_API_Migration_guide.md` (#2018)
via NachoSoto (@NachoSoto)
* `eligiblePromotionalOffers`: don't log error if response is ineligible
(#2019) via NachoSoto (@NachoSoto)
* Runs push-pods after make-release (#2025) via Cesar de la Vega
(@vegaro)
* Some updates on notify-on-non-patch-release-branches: (#2026) via
Cesar de la Vega (@vegaro)
* Deploy `PurchaseTesterSwiftUI` to TestFlight (#2003) via NachoSoto
(@NachoSoto)
* `PurchaseTesterSwiftUI`: added "logs" screen (#2012) via NachoSoto
(@NachoSoto)
* `PurchaseTesterSwiftUI`: allow configuring API key at runtime (#1999)
via NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to our CI configuration files and scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants