-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy PurchaseTesterSwiftUI
to TestFlight
#2003
Conversation
3402f75
to
ce4e7ba
Compare
This is ready 🎉 |
PurchaseTesterSwiftUI
to TestFlight
I'm going to submit a catalyst version too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
lane :deploy_purchase_tester do | ||
match(verbose: true, readonly: true) | ||
increment_build_number( | ||
build_number: latest_testflight_build_number + 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using the CircleCI build number here, but then, this is probably fine as well 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the latest Xcode versions were supposed to auto-bump build numbers?
But then again, that might be only if you use Xcode, not if you go through command line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah and I use that for my own app now, but it wasn't working without bumping the build number manually like this. So they probably built that feature into the UI only (like when Swift shipped 😂)
@@ -0,0 +1 @@ | |||
import("../../../../fastlane/Fastfile") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this I guess the PurchaseTesterSwiftUI
project will have access to all the project fastfile's functions... There are probably many that shouldn't be called from here, but then again, I think it should be ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's fine. It's the same approach we use in the installation tests.
@@ -0,0 +1,6 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the icon is glorious 🎨
lane :deploy_purchase_tester do | ||
match(verbose: true, readonly: true) | ||
increment_build_number( | ||
build_number: latest_testflight_build_number + 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the latest Xcode versions were supposed to auto-bump build numbers?
But then again, that might be only if you use Xcode, not if you go through command line
00ab935
to
e24e7ce
Compare
bd4fb2f
to
2eb7f27
Compare
Fixes [CSDK-510]
2eb7f27
to
d06d403
Compare
**This is an automatic release.** ### Bugfixes * `ISO8601DateFormatter.withMilliseconds`: fixed iOS 11 crash (#2037) via NachoSoto (@NachoSoto) * Changed `StoreKit2Setting.default` back to `.enabledOnlyForOptimizations` (#2022) via NachoSoto (@NachoSoto) ### Other Changes * `Integration Tests`: changed weekly to monthly subscriptions to work around 0-second subscriptions (#2042) via NachoSoto (@NachoSoto) * `Integration Tests`: fixed `testPurchaseWithAskToBuyPostsReceipt` (#2040) via NachoSoto (@NachoSoto) * `ReceiptRefreshPolicy.retryUntilProductIsFound`: default to returning "invalid" receipt (#2024) via NachoSoto (@NachoSoto) * `CachingProductsManager`: use partial cached products (#2014) via NachoSoto (@NachoSoto) * Added `BackendErrorCode.purchasedProductMissingInAppleReceipt` (#2033) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: replaced `Purchases` dependency with `SPM` (#2027) via NachoSoto (@NachoSoto) * `Integration Tests`: changed log output to `raw` (#2031) via NachoSoto (@NachoSoto) * `Integration Tests`: run on iOS 16 (#2035) via NachoSoto (@NachoSoto) * CI: fixed `iOS 14` tests Xcode version (#2030) via NachoSoto (@NachoSoto) * `Async.call`: added non-throwing overload (#2006) via NachoSoto (@NachoSoto) * Documentation: Fixed references in `V4_API_Migration_guide.md` (#2018) via NachoSoto (@NachoSoto) * `eligiblePromotionalOffers`: don't log error if response is ineligible (#2019) via NachoSoto (@NachoSoto) * Runs push-pods after make-release (#2025) via Cesar de la Vega (@vegaro) * Some updates on notify-on-non-patch-release-branches: (#2026) via Cesar de la Vega (@vegaro) * Deploy `PurchaseTesterSwiftUI` to TestFlight (#2003) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: added "logs" screen (#2012) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: allow configuring API key at runtime (#1999) via NachoSoto (@NachoSoto)
Follow up to #2003. Also submitting `macOS` build for [CSDK-510]. Changed this from `Catalyst` to native `macOS` because of this issue: fastlane/fastlane#20826 ![App_store_512](https://user-images.githubusercontent.com/685609/212436414-1fc826a8-5170-49e5-ab69-aac43ce67466.png) [CSDK-510]: https://revenuecats.atlassian.net/browse/CSDK-510?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Fixes CSDK-510.
Depends on #1999.
Also set up CI as per the docs:
Added these 2 environment variables:
SPACESHIP_ONLY_ALLOW_INTERACTIVE_2FA
FASTLANE_SESSION