Created CachingTrialOrIntroPriceEligibilityChecker
#2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
force-pushed
the
trial-checker-cache
branch
from
58b80b8
to
45990bb
Compare
tonidero
approved these changes
Nov 3, 2022
| @available(iOS 13.0, tvOS 13.0, watchOS 6.2, macOS 10.15, *) | ||
| extension TrialOrIntroPriceEligibilityCheckerType { | ||
|
|
||
| func checkEligibility(productIdentifiers: [String]) async -> [String: IntroEligibility] { |
There was a problem hiding this comment.
Hmm, this seems unused other than in tests?
There was a problem hiding this comment.
it's actually public API.
There was a problem hiding this comment.
But that's the completion version, not this one with async right?
There was a problem hiding this comment.
Oooh good catch! I moved this to just the test file.
NachoSoto
force-pushed
the
trial-checker-cache-2
branch
from
0fc4943
to
3d7b147
Compare
NachoSoto
added a commit
that referenced
this pull request
Nov 4, 2022
…ons` This changes the default back to `StoreKit 1`. We decided to do this for the following reasons: - Purchasing with `PromotionalOffer`s does not work with StoreKit 2 due to an Apple bug (see #2020 (comment)) - `checkTrialOrIntroDiscountEligibility` is significantly slower with StoreKit 2 (#1893). We're adding optimizations to help with that (#2007), but the underlying logic will still be slow. - A rare race-condition where `StoreKit 2` does not have transactions after a purchase ([TRIAGE-82]). We have some workarounds (#1945), but it's still being investigated. _ Note: This effectively reverts 0ee540a. That commit made it easier to only change the default in one place which is why this PR is basically just one line._
NachoSoto
added a commit
that referenced
this pull request
Nov 4, 2022
…ons` (#2022) This changes the default back to `StoreKit 1`. We decided to do this for the following reasons: - Purchasing with `PromotionalOffer`s does not work with StoreKit 2 due to an Apple bug (see #2020 (comment)) - `checkTrialOrIntroDiscountEligibility` is significantly slower with `StoreKit 2` (#1893). We're adding optimizations to help with that (#2007), but the underlying logic will still be slow. - A rare race-condition where `StoreKit 2` does not have transactions after a purchase ([TRIAGE-82]). We have some workarounds (#1945), but it's still being investigated. _Note: This effectively reverts 0ee540a. That commit made it easier to only change the default in one place which is why this PR is basically just one line._ [TRIAGE-82]: https://revenuecats.atlassian.net/browse/TRIAGE-82?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
NachoSoto
force-pushed
the
trial-checker-cache-2
branch
from
d45d8bf
to
b08f3e4
Compare
|
Oh wait we need to invalidate this cache when we make purchases or they expire of course 🤦🏻♂️ |
NachoSoto
force-pushed
the
trial-checker-cache-2
branch
from
b08f3e4
to
7eee829
Compare
NachoSoto
changed the base branch from
main
to
notification-subscriptions-changed
NachoSoto
force-pushed
the
trial-checker-cache-2
branch
from
7eee829
to
40e74fd
Compare
|
This is ready for review again @RevenueCat/coresdk, I'm now clearing the cache when subscriptions change (using #2057), which should fix integration tests. |
NachoSoto
force-pushed
the
notification-subscriptions-changed
branch
from
3eddf69
to
2f68cc7
Compare
NachoSoto
force-pushed
the
trial-checker-cache-2
branch
2 times, most recently
from
e348a00
to
f632a4a
Compare
tonidero
approved these changes
Nov 19, 2022
Sources/Purchasing/CachingTrialOrIntroPriceEligibilityChecker.swift
Outdated
Show resolved
Hide resolved
NachoSoto
force-pushed
the
notification-subscriptions-changed
branch
from
2f68cc7
to
eca596c
Compare
NachoSoto
force-pushed
the
trial-checker-cache-2
branch
from
f632a4a
to
5409752
Compare
NachoSoto
force-pushed
the
trial-checker-cache-2
branch
from
6e3087d
to
070785d
Compare
tonidero
approved these changes
Dec 7, 2022
NachoSoto
force-pushed
the
notification-subscriptions-changed
branch
from
a9938b8
to
376e162
Compare
NachoSoto
force-pushed
the
trial-checker-cache-2
branch
from
070785d
to
4eeacdf
Compare
NachoSoto
force-pushed
the
trial-checker-cache-2
branch
from
4eeacdf
to
cb25a28
Compare
NachoSoto
changed the base branch from
notification-subscriptions-changed
to
main
NachoSoto
commented
Jan 5, 2023
| @@ -1235,6 +1238,11 @@ internal extension Purchases { | |||
|
|
|||
| private extension Purchases { | |||
|
|
|||
| func handleCustomerInfoChanged(_ customerInfo: CustomerInfo) { | |||
| self.trialOrIntroPriceEligibilityChecker.clearCache() | |||
There was a problem hiding this comment.
@aboedo per our discussion, this ordering now ensures there are no race conditions.
|
Updated this to clear caches using the existing |
aboedo
approved these changes
Jan 12, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Jan 17, 2023
**This is an automatic release.** ### New Features * Added new `ReceiptParser.fetchAndParseLocalReceipt` (#2204) via NachoSoto (@NachoSoto) * `PurchasesReceiptParser`: added API to parse receipts from `base64` string (#2200) via NachoSoto (@NachoSoto) ### Bugfixes * `CustomerInfo`: support parsing schema version 2 to restore SDK `v3.x` compatibility (#2213) via NachoSoto (@NachoSoto) ### Other Changes * `JSONDecoder`: added decoding type when logging `DecodingError.keyNotFound` (#2212) via NachoSoto (@NachoSoto) * Added `ReceiptParserTests` (#2203) via NachoSoto (@NachoSoto) * Deploy `PurchaseTester` for `macOS` (#2011) via NachoSoto (@NachoSoto) * `ReceiptFetcher`: refactored implementation to log error when failing to fetch receipt (#2202) via NachoSoto (@NachoSoto) * `PostReceiptDataOperation`: replaced receipt `base64` with `hash` for cache key (#2199) via NachoSoto (@NachoSoto) * `PurchaseTester`: small refactor to simplify `Date` formatting (#2210) via NachoSoto (@NachoSoto) * `PurchasesReceiptParser`: improved documentation to reference `default` (#2197) via NachoSoto (@NachoSoto) * Created `CachingTrialOrIntroPriceEligibilityChecker` (#2007) via NachoSoto (@NachoSoto) * Update Gemfile.lock (#2205) via Cesar de la Vega (@vegaro) * remove stalebot in favor of SLAs in Zendesk (#2196) via Andy Boedo (@aboedo) * Update fastlane-plugin-revenuecat_internal to latest version (#2194) via Cesar de la Vega (@vegaro)
NachoSoto
added a commit
that referenced
this pull request
Jul 24, 2023
This will help provide a better experience when launching paywalls, as hopefully we will have already computed intro eligibility by then. This is even better than when using `StoreKit` paywalls. Note that thanks to `CachingTrialOrIntroPriceEligibilityChecker` (#2007) this is cached automatically, and also it handles multiple requests with the same or different product identifiers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CSDK-493.
This will help a little bit with the SK2 performance issues computing eligibility (#1893).