Fix NSNull Attributes crash #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure that the right value is cached for postAttributionData
aboedo
commented
Sep 29, 2020
|
|
||
| @implementation NSDictionary (RCExtensions) | ||
|
|
||
| - (NSDictionary *)removingNSNullValues { |
There was a problem hiding this comment.
turns out this wasn't necessary, but it might be a useful utility. I think there's actually a couple of places where we're doing this manually. So I wasn't sure whether to remove it - there are also tests for it, so I imagine it can't hurt to have it around.
| @@ -155,7 +155,7 @@ - (void)postAttributionData:(NSDictionary *)data | |||
| forAppUserID:appUserID | |||
| completion:^(NSError *_Nullable error) { | |||
| if (error == nil) { | |||
| [self.deviceCache setLatestNetworkAndAdvertisingIdsSent:newData | |||
| [self.deviceCache setLatestNetworkAndAdvertisingIdsSent:newDictToCache | |||
There was a problem hiding this comment.
this is the fix. And totally my bad.
| @@ -55,5 +65,64 @@ class AttributionFetcherTests: XCTestCase { | |||
|
|
|||
| expect { self.attributionFetcher.rot13(randomized) } .to(equal(expected)) | |||
| } | |||
|
|
|||
| func testPostAttributionDataSkipsIfAlreadySent() { | |||
There was a problem hiding this comment.
I overestimated how tested this was - I thought that tests passing for the refactor meant that we were all good, but there weren't really any tests for this stuff.
| from: .adjust, | ||
| forNetworkUserId: userID) | ||
|
|
||
| expect(backend.invokedPostAttributionDataCount) == 1 |
There was a problem hiding this comment.
confirmed that this test fails on develop
vegaro
approved these changes
Sep 29, 2020
Closed
aboedo
added a commit
that referenced
this pull request
Oct 1, 2020
* added test that fails if NSNull value is passed into attribution * added NSDictionary extension to filter out NSNull values * fixed a bug in the test * fix regression * removed unnecessary usage of removingNSNullValues, added tests to ensure that the right value is cached for postAttributionData
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a crash that's been reported through ZenDesk and in RevenueCat/purchases-flutter#105, where calling
addAttributionDatawithNSNullvalues inside theNSDictionarywould make the app crash.The problem is actually a regression in 3.7.0 in the caching of the latest sent values for each network.
breaking line:
https://github.com/RevenueCat/purchases-ios/pull/331/files#diff-16824aa266a8f5da37f049ed477c425bR158
original line:
https://github.com/RevenueCat/purchases-ios/pull/331/files#diff-1f8164986a491f4cc448a01a1161e2bbL395
note that the object cached should have been
newDictToCache, notnewData.