PaywallViewController: expose fontName for CustomFontProvider
#3626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
changed the title
PaywallViewController: expose fontName for CustomFontProvider
NachoSoto
reviewed
Feb 2, 2024
Tests/APITesters/RevenueCatUIAPITester/SwiftAPITester/PaywallViewControllerAPI.swift
Show resolved
Hide resolved
NachoSoto
approved these changes
Feb 2, 2024
Tests/APITesters/RevenueCatUIAPITester/SwiftAPITester/PaywallViewControllerAPI.swift
Outdated
Show resolved
Hide resolved
…iewControllerAPI.swift
NachoSoto
added a commit
that referenced
this pull request
Feb 2, 2024
@Jjastiny) (#3628) Original PR: #3626. This is the iOS counterpart to RevenueCat/purchases-android#1589 This exposes the `fontName` as a parameter and sets `CustomFontProvider`. ### Changes: - Created `updateFontWithFontName` for `PaywallViewController` - Created init function for `offerIdentifier` and `fontName` <img width="450" alt="301765252-95f61abb-10a1-4903-a2ef-12572ae3eaff" src="https://github.com/RevenueCat/purchases-ios/assets/6516487/56061916-0391-447a-ae74-57f2dddcf7a7"> --------- Co-authored-by: Justin Yang <jjastiny@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-androidand hybridsMotivation
This is the ios counter part to RevenueCat/purchases-android#1589
This exposes the fontName as a parameter and sets CustomFontProvider.
Description
Created updateFontWithFontName for PaywallViewController
Created init function for offerIdentifier and fontName