Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jitter and extra cache for background processes #366

Merged
merged 18 commits into from Oct 9, 2020
Merged

Add jitter and extra cache for background processes #366

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7a1cd4e
added a separate value for cache duration to be used when the app is …
aboedo Oct 2, 2020
2008fd6
added jitter for cache updates that start with the app backgrounded.
aboedo Oct 2, 2020
249e032
added purchaserInfoLastUpdatedAt to userDefaults
aboedo Oct 5, 2020
ff4af1e
fixed missing param
aboedo Oct 5, 2020
f6ca9b9
fixed some tests
aboedo Oct 5, 2020
6c0baf1
fixed more tests
aboedo Oct 5, 2020
b42704c
fixed another test
aboedo Oct 5, 2020
23660b2
cleaned up the interface for dispatchWithRandomDelay
aboedo Oct 6, 2020
268bb07
added tests to ensure that newly-created device cache instances read …
aboedo Oct 6, 2020
f301e32
added more tests for device cache
aboedo Oct 6, 2020
b0f4a24
even more device cache tests
aboedo Oct 6, 2020
4dfd0ee
added some new test cases to purchasesTests
aboedo Oct 6, 2020
50240f6
added test to ensure we don't automatically fetch purchaser info onDi…
aboedo Oct 6, 2020
9e3a02a
updated maxJitterInSeconds to 5
aboedo Oct 8, 2020
724a491
formatting of * _Nullable
aboedo Oct 8, 2020
8680bce
simplified conditions and improved nil handling in isPurchaserInfoCac…
aboedo Oct 9, 2020
3904ea4
small cleanup
aboedo Oct 9, 2020
15bbf4a
added test case for migration
aboedo Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion Purchases/Caching/RCDeviceCache.m
View file
Open in desktop
Expand Up @@ -128,9 +128,12 @@ - (void)cachePurchaserInfo:(NSData *)data forAppUserID:(NSString *)appUserID {

- (BOOL)isPurchaserInfoCacheStaleForAppUserID:(NSString *)appUserID isAppBackgrounded:(BOOL)isAppBackgrounded {
NSDate * _Nullable purchaserInfoCachesLastUpdated = [self purchaserInfoCachesLastUpdatedForAppUserID:appUserID];
if (!purchaserInfoCachesLastUpdated) {
return YES;
}
NSTimeInterval timeSinceLastCheck = -[purchaserInfoCachesLastUpdated timeIntervalSinceNow];
int cacheDurationInSeconds = [self cacheDurationInSecondsWithIsAppBackgrounded:isAppBackgrounded];
return !(purchaserInfoCachesLastUpdated != nil && timeSinceLastCheck < cacheDurationInSeconds);
return timeSinceLastCheck >= cacheDurationInSeconds;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much easier to read

}

- (int)cacheDurationInSecondsWithIsAppBackgrounded:(BOOL)isAppBackgrounded {
Expand Down