fix parsing of dates in receipts with milliseconds #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
commented
Oct 8, 2020
| guard let dateBytes = "2020-07-14T19:36:40+0000".data(using: .ascii) else { fatalError() } | ||
| guard let dateBytes = "2020-07-14T19:36:40Z".data(using: .ascii) else { fatalError() } |
There was a problem hiding this comment.
this isn't really necessary, and the code will work in either format, but it resembles the actual strings in receipts a little more closely
|
looks like circleCI is having issues. Tests pass locally, though. |
vegaro
approved these changes
Oct 8, 2020
| let date = Calendar.current.date(from: dateComponents) | ||
| guard let dateBytes = "2020-07-14T19:36:40.202Z".data(using: .ascii) else { fatalError() } | ||
| let receivedDate = ISO3601DateFormatter.shared.date(fromBytes: ArraySlice(dateBytes)) | ||
| expect(receivedDate!.timeIntervalSince1970).to(beCloseTo(date!.timeIntervalSince1970)) |
There was a problem hiding this comment.
We can't compare same way we do in the other test because of the precision issue you mentioned to me in private?
There was a problem hiding this comment.
yeah, floating point precision is a killer here.
There was a problem hiding this comment.
really, we should be doing this on any and all floating point comparisons. I can update the other one.
Closed
aboedo
added a commit
that referenced
this pull request
Oct 9, 2020
* fixed parsing of apple receipts when dates have millisecond resolution * escaped the dot so that it works correctly with international formats * learned to spell milliseconds
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like Apple might have changed the format of dates in receipts, updating the resolution from seconds to milliseconds.
This PR updates our parser so that we handle both cases, since some receipts will still be in the old format even after the update.
More info: https://twitter.com/depth42/status/1313750495710904320