Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paywalls: fix template 1 header overflow #3678

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Paywalls: fix template 1 header overflow #3678

merged 2 commits into from
Feb 13, 2024

Conversation

NachoSoto
Copy link
Contributor

This was mainly visible if pushing PaywallView inside a navigation controller instead of a .sheet or .fullScreenCover.

Before:

Simulator Screenshot - iPhone 15 Pro Max - 2024-02-13 at 10 04 26

After:

Simulator Screenshot - iPhone 15 Pro Max - 2024-02-13 at 10 04 10

This was mainly visible if pushing `PaywallView` inside a navigation controller instead of a `.sheet` or `.fullScreenCover`.

### Before:

### After:
@NachoSoto NachoSoto requested review from a team February 13, 2024 18:08
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, thanks for fixing that 🙏

Copy link
Contributor

@vegaro vegaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@NachoSoto NachoSoto enabled auto-merge (squash) February 13, 2024 18:41
Copy link
Contributor

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@NachoSoto NachoSoto merged commit e3a29e9 into main Feb 13, 2024
24 checks passed
@NachoSoto NachoSoto deleted the fullscreen-clip branch February 13, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants