Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed tests for iOS < 12.2 #372

Merged
merged 1 commit into from Oct 21, 2020
Merged

fixed tests for iOS < 12.2 #372

merged 1 commit into from Oct 21, 2020

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Oct 20, 2020

Tests currently fail on iOS < 12.2, because they assume that the APIs for subscription offers are available.

This fixes those tests.

Tested on my local computer on iOS 11.

We should get CircleCI to also test on old OS versions, but I'm doing that as a part of integration tests later.

@aboedo aboedo requested a review from vegaro October 20, 2020 21:20
@aboedo aboedo self-assigned this Oct 20, 2020
@aboedo aboedo added this to the 3.8.0 milestone Oct 21, 2020
@aboedo aboedo merged commit 517f610 into develop Oct 21, 2020
@aboedo aboedo deleted the fix/tests_on_old_ios_versions branch October 21, 2020 14:45
@aboedo aboedo modified the milestones: 3.8.0, 3.7.5 Oct 22, 2020
@aboedo aboedo mentioned this pull request Oct 22, 2020
@aboedo aboedo mentioned this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants