Fix for passing TargetingContext when using currentOffering(forPlacement:)
#3751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
approved these changes
Mar 6, 2024
| @@ -131,7 +131,8 @@ public extension Offerings { | |||
| returnOffering = placements.fallbackOfferingId.flatMap { self.all[$0]} | |||
| } | |||
|
|
|||
| return returnOffering?.copyWith(placementIdentifier: placementIdentifier) | |||
| return returnOffering?.copyWith(placementIdentifier: placementIdentifier, | |||
| targeting: self.targeting) | |||
There was a problem hiding this comment.
Ohh right... it would be nice if we had something like the copy constructor, that uses the existing values by default unless passed as parameter. We could write it ourselves, but this is ok for now I think.
There was a problem hiding this comment.
This still wouldn't have caught it because this targeting information comes from Offerings and not an Offering 🤷♂️
Targeting context is ONLY in the current offering but when getting an Offering from placements, we get it from all so its not already included
joshdholtz
pushed a commit
that referenced
this pull request
Mar 6, 2024
**This is an automatic release.** ### Bugfixes * Fix for passing `TargetingContext` when using `currentOffering(forPlacement:)` (#3751) via Josh Holtz (@joshdholtz) ### Other Changes * Remove unneeded tests for StoreKit2 with JWS (#3747) via Josh Holtz (@joshdholtz)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Targeting context was not being passed when getting current offering for placement
Description
Offerings.Targetingwhen copyingOfferingwith a placement identifier