[EXTERNAL] Cocoapods support for privacy manifest #3772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
changed the title
aboedo
changed the title
aboedo
changed the base branch from
main
to
privacy_manifest_cocoapods_compatibility
This was referenced Mar 26, 2024
aboedo
added a commit
that referenced
this pull request
Mar 27, 2024
#3775) ### Motivation The library already includes Privacy.xcprivacy in SPM, but when used with CocoaPods (mandatory in Flutter), these files are not exported as the podspec does not include that file as a resource bundle. ### Description Listing the PrivacyInfo.xcprivacy file inside the resource_bundles specification in the podspec allows to distribute the file correctly. Ref. CocoaPods/CocoaPods#10325 (comment) This GitHub issue contains the entire discussion on how to add these xcprivacy files and is referenced in multiple places; many libraries already follow this approach: https://github.com/firebase/firebase-ios-sdk/blob/main/FirebaseCrashlytics.podspec SDWebImage/SDWebImage#3649 flutter/packages#5846 Baseflow/flutter-permission-handler#1291 Baseflow/flutter-geolocator#1462 Co-authored-by: Sergio Durban Belmonte <sergio@durban.cat>
vegaro
pushed a commit
that referenced
this pull request
Apr 1, 2024
|
looking forward for this to be integrated with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The library already includes Privacy.xcprivacy in SPM, but when used with CocoaPods (mandatory in Flutter), these files are not exported as the podspec does not include that file as a resource bundle.
Description
Listing the PrivacyInfo.xcprivacy file inside the resource_bundles specification in the podspec allows to distribute the file correctly. Ref. CocoaPods/CocoaPods#10325 (comment)
This GitHub issue contains the entire discussion on how to add these xcprivacy files and is referenced in multiple places; many libraries already follow this approach:
https://github.com/firebase/firebase-ios-sdk/blob/main/FirebaseCrashlytics.podspec
SDWebImage/SDWebImage#3649
flutter/packages#5846
Baseflow/flutter-permission-handler#1291
Baseflow/flutter-geolocator#1462
Thank you guys for Revenuecat ❤️ !