Create DiagnosticsTracker
#3784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegaro
force-pushed
the
sdk-2905-ios-internal-opt-in-configuration-parameter
branch
2 times, most recently
from
c2efe3e
to
46d6d84
Compare
Base automatically changed from
sdk-2898-ios-ability-to-create-a-jsonl-file-and-internal-api
to
main
April 8, 2024 10:47
vegaro
force-pushed
the
sdk-2905-ios-internal-opt-in-configuration-parameter
branch
from
46d6d84
to
b718aba
Compare
vegaro
force-pushed
the
sdk-2905-ios-internal-opt-in-configuration-parameter
branch
from
a2c959a
to
a6746f0
Compare
tonidero
reviewed
Apr 12, 2024
| } | ||
|
|
||
| func track(_ event: DiagnosticsEvent) async { | ||
| await diagnosticsFileHandler.appendEvent(diagnosticsEvent: event) |
There was a problem hiding this comment.
Hmm I know DiagnosticsFileHandler is an actor, but I think we still need to specify the thread here? We can do this in a separate PR though.
tonidero
reviewed
Apr 12, 2024
| /// Defaults to ``false`` | ||
| /// | ||
| @available(iOS 15.0, tvOS 15.0, macOS 12.0, watchOS 8.0, *) | ||
| @objc internal func with(diagnosticsEnabled: Bool) -> Builder { |
There was a problem hiding this comment.
Added new method as internal for now.
tonidero
approved these changes
Apr 12, 2024
tonidero
deleted the
sdk-2905-ios-internal-opt-in-configuration-parameter
branch
tonidero
reviewed
Apr 12, 2024
| self.diagnosticsFileHandler = diagnosticsFileHandler | ||
| } | ||
|
|
||
| func track(_ event: DiagnosticsEvent) async { |
There was a problem hiding this comment.
We should also add some tests here, just in case. Will do that in follow-up PRs. Nvm, I see we already have tests in the followup PR
vegaro
pushed a commit
that referenced
this pull request
Apr 18, 2024
**This is an automatic release.** ### New Features * Paywalls: Allow closed button color to be configured (#3805) via Josh Holtz (@joshdholtz) ### Other Changes * Create `DiagnosticsTracker` (#3784) via Cesar de la Vega (@vegaro) * Add DiagnosticsSynchronizer (#3787) via Cesar de la Vega (@vegaro) * Update Package.resolved (#3796) via Cesar de la Vega (@vegaro) --------- Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
DiagnosticsTrackerand adds it to thePurchasesinitialization. I don't expose thediagnosticsEnabledyet