Fix/race condition after uninstalling app #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efore crashing if it's removed.
…UserID had never been set, the app won't crash
vegaro
reviewed
Nov 7, 2020
Purchases/Caching/RCDeviceCache.m
Outdated
| @@ -109,6 +112,7 @@ - (void)clearCachesForAppUserID:(NSString *)oldAppUserID andSaveNewUserID:(NSStr | |||
| [self deleteAttributesIfSyncedForAppUserID:oldAppUserID]; | |||
|
|
|||
| [self cacheAppUserID:newUserID]; | |||
| self.appUserIDHasBeenSet = YES; | |||
There was a problem hiding this comment.
Should we move this to cacheAppUserId? That way if another function calls that function, we won't forget to set this bool
There was a problem hiding this comment.
yeah, good call. don't know what I was thinking.
vegaro
approved these changes
Nov 9, 2020
Purchases/Caching/RCDeviceCache.m
Outdated
| @@ -99,7 +99,10 @@ - (nullable NSString *)cachedAppUserID { | |||
| } | |||
|
|
|||
| - (void)cacheAppUserID:(NSString *)appUserID { | |||
| [self.userDefaults setObject:appUserID forKey:RCAppUserDefaultsKey]; | |||
| @synchronized (self) { | |||
| self.appUserIDHasBeenSet = YES; | |||
There was a problem hiding this comment.
Would it make sense to move this right after the set in the userDefaults? Just in case it fails when calling setObject
There was a problem hiding this comment.
good idea! In practice, I don't think we're actually catching the error anywhere so it'd crash, but if we did add a try / catch this would lead to an inconsistent state.
Updated.
… when setting the object
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #375
Fixes an issue where if the app modifies other userDefaults preferences, and the appUserID had never been set in RevenueCat, the SDK will crash.