fix overflow of web_order_line_item_id in 32-bit devices #384
Conversation
| @@ -6,12 +6,12 @@ | |||
| import Foundation | |||
|
|
|||
| extension ArraySlice where Element == UInt8 { | |||
| func toUInt() -> UInt { | |||
| func toUInt() -> UInt64 { | |||
There was a problem hiding this comment.
this isn't strictly necessary, but it doesn't do any harm other than parsing ever-so-slightly slower on 32-bit devices.
The alternative was to write essentially the same method twice, once with UInt and the other one with UInt64.
| func toInt64() -> Int64 { | ||
| return Int64(self.toUInt()) | ||
| } | ||
|
|
There was a problem hiding this comment.
This method is exactly the same as toInt on 64-bit devices.
| func int64Container(int64: Int64) -> ASN1Container { | ||
| let intAsBytes = int64ToBytes(int: int64) | ||
| let bytesUsedForLength = intAsBytes.count < 128 ? 1 : intToBytes(int: intAsBytes.count).count + 1 | ||
|
|
||
| return ASN1Container(containerClass: .application, | ||
| containerIdentifier: .octetString, | ||
| encodingType: .primitive, | ||
| length: ASN1Length(value: intAsBytes.count, bytesUsedForLength: bytesUsedForLength), | ||
| internalPayload: ArraySlice(intAsBytes), | ||
| internalContainers: []) | ||
| } |
There was a problem hiding this comment.
this is the same as intContainer, but with 64. Maybe it's because I'm really tired on a Friday, but I couldn't think of a much better way to do this avoiding duplication. Open to ideas.
There was a problem hiding this comment.
same for the other changes in this class
There was a problem hiding this comment.
I think it's fine. It's more clear like this and they are not huge functions
Addresses #379
the
web_order_line_item_idis actually a 64-bit integer, so parsing it would crash on 32-bit devices.This PR forces the type to
Int64, which will of course be slower but work correctly.I believe there's another issue in 64-bit devices, because unrelated tests are not passing correctly for me on iPhone 5. I'll work on those separately.