[Customer Center] Add API call to get Customer Center config #3933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegaro
force-pushed
the
sdk-3472-add-hardcoded-response-to-sdk
branch
from
9423df6
to
c350297
Compare
vegaro
force-pushed
the
sdk-3472-add-hardcoded-response-to-sdk
branch
2 times, most recently
from
26fb266
to
abb1c50
Compare
vegaro
changed the title
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 17, 2024
vegaro
force-pushed
the
sdk-3433-supportview
branch
from
c0a38a1
to
25222e9
Compare
vegaro
force-pushed
the
sdk-3472-add-hardcoded-response-to-sdk
branch
from
8957234
to
2f36ec7
Compare
vegaro
force-pushed
the
sdk-3433-supportview
branch
from
25222e9
to
0309db3
Compare
vegaro
force-pushed
the
sdk-3472-add-hardcoded-response-to-sdk
branch
from
2f36ec7
to
2d41724
Compare
vegaro
changed the title
tonidero
approved these changes
Jun 18, 2024
tonidero
reviewed
Jun 18, 2024
vegaro
force-pushed
the
sdk-3433-supportview
branch
from
0309db3
to
9c89313
Compare
vegaro
force-pushed
the
sdk-3472-add-hardcoded-response-to-sdk
branch
3 times, most recently
from
ad260d3
to
3dd2fb0
Compare
vegaro
force-pushed
the
sdk-3433-supportview
branch
from
2858c16
to
8f21718
Compare
vegaro
force-pushed
the
sdk-3472-add-hardcoded-response-to-sdk
branch
from
3dd2fb0
to
821016e
Compare
Base automatically changed from
sdk-3433-supportview
to
integration/customer_support_workflow
June 28, 2024 10:16
vegaro
force-pushed
the
integration/customer_support_workflow
branch
from
4ab05c3
to
5fcbe86
Compare
tonidero
approved these changes
Jul 8, 2024
| locale: "en_US", | ||
| localizedStrings: [ | ||
| "cancel": "Cancel", | ||
| "back": "Back" |
There was a problem hiding this comment.
We should get a list of all these strings so we verify they are added in the backend as well, so the SDK can trust they exist and make it an object when parsing it... But for now I'm ok with this.
Tests/UnitTests/Networking/Backend/BackendGetCustomerCenterConfigTests.swift
Outdated
Show resolved
Hide resolved
vegaro
force-pushed
the
sdk-3472-add-hardcoded-response-to-sdk
branch
from
09cb7eb
to
982d7a6
Compare
…-sdk` - macos (#4030) Requested by @vegaro for [sdk-3472-add-hardcoded-response-to-sdk](https://github.com/RevenueCat/purchases-ios/tree/sdk-3472-add-hardcoded-response-to-sdk)
…-sdk` - ios-14 (#4032) Requested by @vegaro for [sdk-3472-add-hardcoded-response-to-sdk](https://github.com/RevenueCat/purchases-ios/tree/sdk-3472-add-hardcoded-response-to-sdk)
…-sdk` - ios-17 (#4031) Requested by @vegaro for [sdk-3472-add-hardcoded-response-to-sdk](https://github.com/RevenueCat/purchases-ios/tree/sdk-3472-add-hardcoded-response-to-sdk)
vegaro
force-pushed
the
integration/customer_support_workflow
branch
from
202b5c6
to
3467940
Compare
vegaro
force-pushed
the
sdk-3472-add-hardcoded-response-to-sdk
branch
from
4bbc8de
to
7268b6f
Compare
vegaro
force-pushed
the
sdk-3472-add-hardcoded-response-to-sdk
branch
3 times, most recently
from
3dcc74f
to
e0b4ea4
Compare
vegaro
force-pushed
the
sdk-3472-add-hardcoded-response-to-sdk
branch
from
e0b4ea4
to
93ccbc5
Compare
vegaro
merged commit 8099f65
into
integration/customer_support_workflow
26 checks passed
vegaro
added a commit
that referenced
this pull request
Jul 9, 2024
Adds `Purchases.shared.loadCustomerCenter()` that calls a new backend endpoint that returns the customer center configuration This API call doesn't exist yet and it will change. This PR is the ground work so that we don't have to wait for the backend to add this API and we can already pretend the API is there. --------- Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
vegaro
added a commit
that referenced
this pull request
Jul 11, 2024
Based off #3933 https://github.com/RevenueCat/purchases-ios/assets/664544/11eae984-294a-4e14-8c40-7c2d50994c09 Can probably use some animations, but tuning that up will come up later It will open a feedback survey for an option if there's one
vegaro
added a commit
that referenced
this pull request
Jul 15, 2024
Adds `Purchases.shared.loadCustomerCenter()` that calls a new backend endpoint that returns the customer center configuration This API call doesn't exist yet and it will change. This PR is the ground work so that we don't have to wait for the backend to add this API and we can already pretend the API is there. --------- Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
vegaro
added a commit
that referenced
this pull request
Jul 15, 2024
Based off #3933 https://github.com/RevenueCat/purchases-ios/assets/664544/11eae984-294a-4e14-8c40-7c2d50994c09 Can probably use some animations, but tuning that up will come up later It will open a feedback survey for an option if there's one
vegaro
added a commit
that referenced
this pull request
Jul 17, 2024
Adds `Purchases.shared.loadCustomerCenter()` that calls a new backend endpoint that returns the customer center configuration This API call doesn't exist yet and it will change. This PR is the ground work so that we don't have to wait for the backend to add this API and we can already pretend the API is there. --------- Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
vegaro
added a commit
that referenced
this pull request
Jul 17, 2024
Based off #3933 https://github.com/RevenueCat/purchases-ios/assets/664544/11eae984-294a-4e14-8c40-7c2d50994c09 Can probably use some animations, but tuning that up will come up later It will open a feedback survey for an option if there's one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Purchases.shared.loadCustomerCenter()that calls a new backend endpoint that returns the customer center configurationThis API call doesn't exist yet and it will change. This PR is the ground work so that we don't have to wait for the backend to add this API and we can already pretend the API is there.